Re: [Qemu-devel] [PATCH 1/6] hw/9pfs: Add reference counting for fid

["Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>]

On Thu, 09 Jun 2011 16:10:39 -0700, Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com> wrote:
> On 06/06/2011 10:16 AM, Aneesh Kumar K.V wrote:
> > Signed-off-by: Aneesh Kumar K.V<aneesh.kumar@linux.vnet.ibm.com>
> 
> Just one minor issue below; otherwise
> 
> Reviewed-by: Venkateswararao Jujjuri "<jvrao@linux.vnet.ibm.com>
> 
> > ---
....

> >   hw/9pfs/virtio-9p.c |  205 +++++++++++++++++++++++++++++++++++----------------
> >
> >       pdu_unmarshal(pdu, offset, "dd",&fid,&datasync);
> > -    fidp = lookup_fid(s, fid);
> > +    fidp = get_fid(s, fid);
> >       if (fidp == NULL) {
> >           err = -ENOENT;
> >           goto out;
> > @@ -1444,6 +1465,7 @@ static void v9fs_fsync(void *opaque)
> >           err = offset;
> >       }
> >   out:
> > +    put_fid(fidp);
> It should be
> 
> put_fid(fidp);
> 
> out_nofid:
> 

ok


> >       complete_pdu(s, pdu, err);
> >   }


-aneesh