Re: [PM-WIP_CPUFREQ][PATCH 1/6 v2] OMAP2+: cpufreq: free up table on exit

[Kevin Hilman <khilman@ti.com>]

Nishanth Menon <nm@ti.com> writes:

> freq_table allocated by opp_init_cpufreq_table in omap_cpu_init
> needs to be freed in omap_cpu_exit.

Actually it needs to be freed by a corresponding OPP layer function.

IOW, what happens if the OPP core code switches from using kmalloc to
static tables, or something else?    The cleanup should be done by the
same layer that does the init/alloc.

Kevin

> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm/mach-omap2/omap2plus-cpufreq.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> index d53ce23..e38ebb8 100644
> --- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
> +++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
> @@ -26,6 +26,7 @@
>  #include <linux/clk.h>
>  #include <linux/io.h>
>  #include <linux/opp.h>
> +#include <linux/slab.h>
>  #include <linux/cpu.h>
>  
>  #include <asm/system.h>
> @@ -216,6 +217,8 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
>  static int omap_cpu_exit(struct cpufreq_policy *policy)
>  {
>  	clk_exit_cpufreq_table(&freq_table);
> +	kfree(freq_table);
> +	freq_table = NULL;
>  	clk_put(mpu_clk);
>  	return 0;
>  }