From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 4/4] module: Use the binary search for symbols resolution Date: Tue, 19 Apr 2011 11:07:43 +0930 Message-ID: <87liz73tso.fsf@rustcorp.com.au> References: <1302960373-5309-1-git-send-email-abogani@kernel.org> <1302960373-5309-5-git-send-email-abogani@kernel.org> Mime-Version: 1.0 Return-path: In-Reply-To: Sender: linux-embedded-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: wanlong.gao@gmail.com, Alessio Igor Bogani Cc: Tim Abbott , Anders Kaseorg , Jason Wessel , Tim Bird , LKML , Linux Embedded On Sat, 16 Apr 2011 22:32:08 +0800, Wanlong Gao wrote: > > + sym = bsearch(fsa->name, syms->start, syms->stop - syms->start, > As the bsearch func, why not change the syms->stop to syms->end ? > Hmm..Just a stupid suggestion. The names are derived from the linker symbols for end of sections, which is __stop_. Cheers, Rusty.