From: Kevin Hilman <khilman@deeprootsystems.com>
To: Matt Fleming <matt@console-pimps.org>
Cc: linux-omap@vger.kernel.org,
Madhusudhan Chikkature <madhu.cr@ti.com>,
Adrian Hunter <adrian.hunter@nokia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tony Lindgren <tony@atomide.com>,
Denis Karpov <ext-denis.2.karpov@nokia.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] MMC: OMAP HS-MMC: convert to dev_pm_ops
Date: Fri, 14 May 2010 09:51:21 -0700 [thread overview]
Message-ID: <87ljbmmnp2.fsf@deeprootsystems.com> (raw)
In-Reply-To: <87k4r74p01.fsf@linux-g6p1.site> (Matt Fleming's message of "Thu\, 13 May 2010 19\:48\:14 +0100")
Matt Fleming <matt@console-pimps.org> writes:
> On Tue, 11 May 2010 14:57:16 -0700, Kevin Hilman <khilman@deeprootsystems.com> wrote:
>>
>> Note that dev_pm_ops version of the suspend hook no longer takes a
>> 'state' argument. However, the MMC core function mmc_suspend_host()
>> still takes a 'state' argument, but it is unused, so a dummy
>> state variable was created to pass to the MMC core.
>
> Hmm.. instead of passing this dummy state argument why don't we just
> remove the argument from mmc_suspend_host()? Like you said, it's unused,
> so I don't see a reason to keep it around?
I don't see a reason either, but it requires patching the MMC core as
well as all the users. As I'm not an MMC core person, I thought this
best left to someone in that domain.
Fixing the core and callers could easily be done on top of this patch.
Kevin
next prev parent reply other threads:[~2010-05-14 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 21:57 [PATCH] MMC: OMAP HS-MMC: convert to dev_pm_ops Kevin Hilman
2010-05-13 18:48 ` Matt Fleming
2010-05-14 16:51 ` Kevin Hilman [this message]
2010-05-14 22:57 ` Matt Fleming
2010-05-18 16:34 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljbmmnp2.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=ext-denis.2.karpov@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=matt@console-pimps.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.