All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
To: Andreas Dilger <andreas.dilger@oracle.com>
Cc: hch@infradead.org, viro@zeniv.linux.org.uk, adilger@Sun.COM,
	corbet@lwn.net, serue@us.ibm.com, neilb@suse.de,
	linux-fsdevel@vger.kernel.org, sfrench@us.ibm.com
Subject: Re: [PATCH -V6 0/8] Generic name to handle and open by handle syscalls
Date: Wed, 28 Apr 2010 10:39:54 +0530	[thread overview]
Message-ID: <87ljc89n8d.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <2ED2587E-A03D-4C3B-8E7E-711434C7736C@oracle.com>

On Tue, 27 Apr 2010 15:13:20 -0600, Andreas Dilger <andreas.dilger@oracle.com> wrote:
> 
> On 2010-04-27, at 10:13, Aneesh Kumar K.V wrote:
> > Changes from V5:
> > a) added sys_name_to_handle_at syscall which takes AT_SYMLINK_NOFOLLOW flag 
> >   instead of two syscalls sys_name_to_handle and sys_lname_to_handle.
> > 
> > #define AT_FDCWD		-100
> > #define AT_SYMLINK_NOFOLLOW	0x100
> > 
> > static int name_to_handle(const char *name, struct file_handle  *fh)
> > {
> > 	return syscall(338, AT_FDCWD, name, fh, 0);
> > }
> > 
> > static int lname_to_handle(const char *name, struct file_handle  *fh)
> > {
> > 	return syscall(338, AT_FDCWD, name, fh, AT_SYMLINK_NOFOLLOW);
> > }
> > 
> > static int open_by_handle(struct file_handle *fh,  int flags)
> > {
> > 	return syscall(339, fh, flags);
> > }
> > 
> > static int freadlink(int fd, char *buf, size_t bufsiz)
> > {
> > 	return syscall(340, fd, buf, bufsiz);
> > }
> 
> Your example, while #defining the AT_* stuff, did not actually change to use the _at() interface.
> 

I retained  the name name_to_handle and lname_to_handle in the example
but used the same syscall number for both with right flags. So it
should be using syscall sys_name_to_handle_at

-aneesh

      reply	other threads:[~2010-04-28  5:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-27 16:13 [PATCH -V6 0/8] Generic name to handle and open by handle syscalls Aneesh Kumar K.V
2010-04-27 16:13 ` [PATCH -V6 1/8] exportfs: Return the minimum required handle size Aneesh Kumar K.V
2010-04-27 16:13 ` [PATCH -V6 2/8] vfs: Add name to file handle conversion support Aneesh Kumar K.V
2010-04-27 16:13 ` [PATCH -V6 3/8] vfs: Add open by file handle support Aneesh Kumar K.V
2010-04-27 16:13 ` [PATCH -V6 4/8] vfs: Add freadlink syscall Aneesh Kumar K.V
2010-04-27 16:13 ` [PATCH -V6 5/8] ext4: Add get_fsid callback Aneesh Kumar K.V
2010-04-27 16:13 ` [PATCH -V6 6/8] x86: Add new syscalls for x86_32 Aneesh Kumar K.V
2010-04-27 16:45   ` Aneesh Kumar K. V
2010-04-27 16:13 ` [PATCH -V6 7/8] x86: Add new syscalls for x86_64 Aneesh Kumar K.V
2010-04-27 16:13 ` [PATCH -V6 8/8] ext3: Add get_fsid callback Aneesh Kumar K.V
2010-04-27 21:13 ` [PATCH -V6 0/8] Generic name to handle and open by handle syscalls Andreas Dilger
2010-04-28  5:09   ` Aneesh Kumar K. V [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ljc89n8d.fsf@linux.vnet.ibm.com \
    --to=aneesh.kumar@linux.vnet.ibm.com \
    --cc=adilger@Sun.COM \
    --cc=andreas.dilger@oracle.com \
    --cc=corbet@lwn.net \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=serue@us.ibm.com \
    --cc=sfrench@us.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.