All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik-GANU6spQydw@public.gmane.org>
To: Frank Seidel <frank-aMRDT+nbkrEb1SvskN2V4Q@public.gmane.org>
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: I2C pxa regression
Date: Sun, 08 Mar 2009 19:37:57 +0100	[thread overview]
Message-ID: <87ljrf6et6.fsf@free.fr> (raw)

Hi,

In linux-next, the commit named "i2c: Add missing KERN_* constants to printks",
id 77130fc992cfdcce8c0a748a2daef16fc16e76bb, breaks compilation for pxa
architectures.

I think that hunk should be amended :

> diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
> index bdb1f75..bfa4586 100644
> --- a/drivers/i2c/busses/i2c-pxa.c
> +++ b/drivers/i2c/busses/i2c-pxa.c
> @@ -210,11 +210,12 @@ static irqreturn_t i2c_pxa_handler(int this_irq, void *dev_id);
>  static void i2c_pxa_scream_blue_murder(struct pxa_i2c *i2c, const char *why)
>  {
>         unsigned int i;
> -       printk("i2c: error: %s\n", why);
> -       printk("i2c: msg_num: %d msg_idx: %d msg_ptr: %d\n",
> +       printk(KERN_ERR "i2c: error: %s\n", why);
> +       printk(KERN_ERR "i2c: msg_num: %d msg_idx: %d msg_ptr: %d\n",
>                 i2c->msg_num, i2c->msg_idx, i2c->msg_ptr);
> -       printk("i2c: ICR: %08x ISR: %08x\n"
> -              "i2c: log: ", readl(_ICR(i2c)), readl(_ISR(i2c)));
> +       printk(KERN_ERR "i2c: ICR: %08x ISR: %08x\n"
                                                      \-> a comma would be
                                                      welcome here.
> +              readl(_ICR(i2c)), readl(_ISR(i2c)));
> +       printk(KERN_DEBUG "i2c: log: ");
>         for (i = 0; i < i2c->irqlogidx; i++)
>                 printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
>         printk("\n");

Cheers.

--
Robert

             reply	other threads:[~2009-03-08 18:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-08 18:37 Robert Jarzmik [this message]
     [not found] ` <87ljrf6et6.fsf-GANU6spQydw@public.gmane.org>
2009-03-08 19:05   ` I2C pxa regression Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ljrf6et6.fsf@free.fr \
    --to=robert.jarzmik-ganu6spqydw@public.gmane.org \
    --cc=frank-aMRDT+nbkrEb1SvskN2V4Q@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.