All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@nokia.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [ath5k-devel] [PATCH] ath5k: fix detection of jumbo frames
Date: Mon, 03 Nov 2008 09:29:00 +0200	[thread overview]
Message-ID: <87ljw1b743.fsf@nokia.com> (raw)
In-Reply-To: <43e72e890811021300o6bef49b0i515d0f72974cef00@mail.gmail.com> (ext Luis R. Rodriguez's message of "Sun\, 2 Nov 2008 13\:00\:27 -0800")

(Trimmed CC list)

Luis R. Rodriguez <lrodriguez@atheros.com> writes:

>>, and, since
>> 63266a653589e1a237527479f10212ea77ce7844 "ath5k: rates cleanup", we do not fall back to the basic rate, such packets would trigger
>> the following WARN_ON:
>
> So its slow because using rate 0 takes a while? If indeed you don't
> see a valid use for this rate I'd say to completely disallow it and
> use BUG_ON() on it.

Please, avoid BUG_ON() at all costs, only use it if the situation
might mean major data corruption or something similar. For users
BUG_ON() is a major grief because there are no visible indication what
has happened.

IMHO wireless drivers should not have BUG_ON() calls at all, WARN_ON()
is enough and much more usable for everyone.

-- 
Kalle Valo

  parent reply	other threads:[~2008-11-03  7:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-02 19:08 [PATCH] ath5k: fix detection of jumbo frames Bob Copeland
2008-11-02 19:08 ` Bob Copeland
2008-11-02 21:00 ` [ath5k-devel] " Luis R. Rodriguez
2008-11-02 21:00   ` Luis R. Rodriguez
2008-11-02 21:52   ` Bob Copeland
2008-11-02 21:52     ` Bob Copeland
2008-11-02 22:33     ` Luis R. Rodriguez
2008-11-02 22:33       ` Luis R. Rodriguez
2008-11-03  2:44       ` Bob Copeland
2008-11-03  2:44         ` Bob Copeland
2008-11-03  7:29   ` Kalle Valo [this message]
2008-11-03 13:35 ` Pavel Roskin
2008-11-03 13:35   ` Pavel Roskin
2008-11-03 14:26   ` [ath5k-devel] " Bob Copeland
2008-11-03 14:26     ` Bob Copeland
2008-11-03 14:40     ` Pavel Roskin
2008-11-03 14:40       ` Pavel Roskin
2008-11-04  3:14 ` [PATCH] ath5k: correct handling of rx status fields Bob Copeland
2008-11-04  3:14   ` Bob Copeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ljw1b743.fsf@nokia.com \
    --to=kalle.valo@nokia.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.