From: Marco Gerards <mgerards@xs4all.nl>
To: Pavel Roskin <proski@gnu.org>
Cc: grub-devel@gnu.org
Subject: Re: [PATCH] Enable writing to ATA devices, fix several bugs
Date: Thu, 03 Jul 2008 20:27:15 +0200 [thread overview]
Message-ID: <87lk0i6cxo.fsf@xs4all.nl> (raw)
In-Reply-To: <20080703001716.13881.1754.stgit@dv.roinet.com> (Pavel Roskin's message of "Wed, 02 Jul 2008 20:17:16 -0400")
Pavel Roskin <proski@gnu.org> writes:
> We have save_env now, so we can use the write capability. This also
> fixes the last compiler warning in GRUB.
Great!
> Sorry, Marco, please ignore the previous message, as it didn't get to
> the list.
The more patches I get, the better ;-)
> ChangeLog:
>
> * disk/ata.c (grub_ata_pio_write): Check status before writing,
> like we do in grub_ata_pio_read().
>
> (grub_ata_readwrite): Always write individual sectors. Fix the
> sector count for the remainder.
Why?
> (grub_ata_write): Enable writing to ATA devices. Correctly
> report error for ATAPI devices.
Great! Did you test this?
If you can fix Roberts comment, it would be great! Can you commit it
afterwards?
--
Marco
next prev parent reply other threads:[~2008-07-03 18:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 0:17 [PATCH] Enable writing to ATA devices, fix several bugs Pavel Roskin
2008-07-03 14:10 ` Robert Millan
2008-07-03 18:27 ` Marco Gerards [this message]
2008-07-03 20:50 ` Pavel Roskin
2008-07-04 11:50 ` Marco Gerards
2008-07-04 17:07 ` Pavel Roskin
2008-07-20 18:55 ` Marco Gerards
2008-07-20 20:24 ` Pavel Roskin
2008-07-21 12:49 ` Marco Gerards
2008-07-21 13:19 ` Javier Martín
2008-07-21 15:20 ` Marco Gerards
2008-07-21 15:33 ` Javier Martín
2008-07-21 15:56 ` Marco Gerards
2008-07-21 15:41 ` Pavel Roskin
2008-07-21 15:53 ` Marco Gerards
2008-07-21 16:00 ` Pavel Roskin
2008-07-21 16:10 ` Marco Gerards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lk0i6cxo.fsf@xs4all.nl \
--to=mgerards@xs4all.nl \
--cc=grub-devel@gnu.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.