From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JKogB-0000AX-Eo for mharc-grub-devel@gnu.org; Fri, 01 Feb 2008 00:43:11 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JKog9-00008j-4V for grub-devel@gnu.org; Fri, 01 Feb 2008 00:43:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JKog6-00006F-Bd for grub-devel@gnu.org; Fri, 01 Feb 2008 00:43:07 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JKog6-000067-7s for grub-devel@gnu.org; Fri, 01 Feb 2008 00:43:06 -0500 Received: from smtp-vbr10.xs4all.nl ([194.109.24.30]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JKog5-00083m-Rw for grub-devel@gnu.org; Fri, 01 Feb 2008 00:43:06 -0500 Received: from localhost.localdomain (249-174.surfsnel.dsl.internl.net [145.99.174.249]) by smtp-vbr10.xs4all.nl (8.13.8/8.13.8) with ESMTP id m115h31O089299 for ; Fri, 1 Feb 2008 06:43:04 +0100 (CET) (envelope-from mgerards@xs4all.nl) From: Marco Gerards To: The development of GRUB 2 References: <87prvhg44e.fsf@xs4all.nl> Mail-Copies-To: mgerards@xs4all.nl Date: Fri, 01 Feb 2008 06:44:44 +0100 In-Reply-To: (bean123ch@gmail.com's message of "Fri, 1 Feb 2008 11:31:36 +0800") Message-ID: <87lk65fcxf.fsf@xs4all.nl> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Virus-Scanned: by XS4ALL Virus Scanner X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.9 Subject: Re: [PATCH] btree support in xfs driver X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2008 05:43:09 -0000 Bean writes: > On Feb 1, 2008 3:57 AM, Marco Gerards wrote: >> Bean writes: >> >> Hi Bean! >> >> > I add btree support for the xfs driver, and fix a few bugs. Now i' m >> > able to list a directory of over 5000 files, please test it. >> >> You rock! >> >> Can you load big files now, that are stored in BTrees. Did you use >> code from elsewhere? > > it should be, grub_xfs_read_block is used by both file and directory. > >> >> > 2008-02-01 Bean >> > >> > * fs/xfs.h (grub_xfs_sblock): New member log2_dirblk. >> > (grub_xfs_btree_node): New structure. >> > (grub_xfs_btree_root): New structure. >> > (grub_xfs_inode): New member nblocks, extsize, nextents and btree. >> >> members >> >> > (GRUB_XFS_EXTENT_OFFSET): Use exts instead of inode->data.extents. >> > (GRUB_XFS_EXTENT_BLOCK): Likewise. >> > (GRUB_XFS_EXTENT_SIZE): Likewise. >> > (grub_xfs_read_block): Support btree format type. >> > (grub_xfs_iterate_dir): Use regparm(1) attribute in call_hook. >> > Use directory block as basic unit. >> >> This won't work on non-i386. So I think this has to be fixed like >> that other bug, for example with the autoconf check extension you >> proposed. > > i take a look at the aclocal.m4, the place where NESTED_FUNC_ATTR is defined: > > AC_MSG_RESULT([$grub_cv_i386_check_nested_functions]) > > if test "x$grub_cv_i386_check_nested_functions" = xyes; then > AC_DEFINE([NESTED_FUNC_ATTR], > [__attribute__ ((__regparm__ (2)))], > [Catch gcc bug]) > else > dnl Unfortunately, the above test does not detect a bug in gcc-4.0. > dnl So use regparm 2 until a better test is found. > AC_DEFINE([NESTED_FUNC_ATTR], > [__attribute__ ((__regparm__ (2)))], > [Catch gcc bug]) > fi > > is there a problem here ? i think NESTED_FUNC_ATTR is defined > regardless of the test result. Ehm, this is weird. This wasn't here from the beginning, right? But at least this is on i386 only... -- Marco