Re: [patch] add i2c_clients_command()

[Gerd Knorr <kraxel@bytesex.org>]

Christoph Hellwig <hch@infradead.org> writes:

> > +void i2c_clients_command(struct i2c_adapter *adap, unsigned int cmd, void *arg)
> > +{
> > +	int i;
> > +
> > +	down(&adap->list);
> > +	for (i = 0; i < I2C_CLIENT_MAX; i++) {
> > +		if (NULL == adap->clients[i])
> > +			continue;

> This is a horrible algorithm!  Please introduce a per-adapter client
> lists.

Well, I can't easily fix that single function.  The whole i2c core
manages the clients that way, i.e. the whole i2c subsystem would need
a rewrite ...

  Gerd

-- 
Michael Moore for president!