From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793563954; b=s/t7O4U2r3BGWIz9pdUwAA4t5Wk5/ExpFT3faLr1SdjOFXy7zrdebl+2y1Py83hgeEV5 VDgrsSchUICCHz1mpCXoCgIoADKR4sfUGoO1oHgvuBpaUCNldmwRf3gqfgPTyO2Y1rJnr 4t3KPfDSMUAS6IrZinIARSvRB2qFoFW2EqwnsZHSzmTLjIfJDA1i7fEdF7BLQROm1XUK0 EILcau3HEBjykO/zm0iWBEnrdaWVmZVIKWBJDqduiQGpTzvarj2tu0n1d3aC/w9giOiB3 Q/RwoJiVjb/aewMWaVBcT3nqL9buxvMtLpl92HCC2dAfUkOu9Ot710NjMRpbsZ/TU5A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793563954; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:Received:Resent-To: Resent-From:Resent-Date:Resent-Message-ID:From:To:Cc:Subject: In-Reply-To:References:Date:Message-ID:User-Agent:MIME-Version: Content-Type:Content-Transfer-Encoding:Lines:X-Scanned-By; bh=oNopvIrGwggCQ0510MgqgZL4xJk+ROUgtmVb33nxu5Y=; b=UBLPUO0DuYeewx0mxrKX37PzTh/mwzDkJ7oyrV71Gph1Uj6VwU3ykK3uPRFqnPGmmETc qYUVSZgAFOJ72CzH5cxhBhouy4wFVYzUDH/hTt7pdIzLFWJkCkYtOzz3JKsYL2xusELMw JQfhYn1p1ZHy3PufwNv5/pQHAa25YAy0tMGrM9UQDZLCtDEYNcySGDnawZoycEfIBCsBs VkvEQG88WxDx9cDevn4hhvkYyRZGzLexif8jZs40tw+R3M8jcKNRWR4KRolrFFRA8wPRU n30emQ3i+4/Uoh0VZdPQgza4pszmbIt5x0FeTQOHahtrTMx5JhU6F4PMtWVPLQ26Bgw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=du+2YA9N; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B644E606A325 for ; Sun, 1 Nov 2026 20:12:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B644E606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=du+2YA9N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793563953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-message-id:in-reply-to:in-reply-to: references:references; bh=oNopvIrGwggCQ0510MgqgZL4xJk+ROUgtmVb33nxu5Y=; b=du+2YA9Nflw4J2Quok8v5zdQlDRCvaCHoAMdKGsvA9661afpN9Wj5Qhft8P80Oc4lhiudG aJixyjpNqqkLm1/zY/lD3do7Pe8DUN2PsSOha63zqhFuBwFx+ASwPQVOCUjRXR5QRtyMsq LpQEgV+x/xGTkGxiH82r9s0Zqa7H0oM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-400--bl76eGfOWKWgGNyjcKPkw-1; Sun, 01 Nov 2026 15:12:27 -0500 X-MC-Unique: -bl76eGfOWKWgGNyjcKPkw-1 X-Mimecast-MFC-AGG-ID: -bl76eGfOWKWgGNyjcKPkw_1793563943 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CA7C11955BFE; Sun, 1 Nov 2026 20:12:21 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.2]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9BF59767; Sun, 1 Nov 2026 20:12:19 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3331821E6A04; Sun, 01 Nov 2026 21:12:17 +0100 (CET) Resent-To: pasic@linux.ibm.com, 17746591750@163.com, rathc@linux.ibm.com, alistair@alistair23.me, stefanb@linux.vnet.ibm.com, graf@amazon.com, xen-devel@lists.xenproject.org, FangSheng.Huang@amd.com, luc@lmichel.fr, michael.roth@amd.com, lixianglai@loongson.cn, maobibo@loongson.cn, pbarbuda@microsoft.com, yoshinori.sato@nifty.com, qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, john.levon@nutanix.com, thanos.makatos@nutanix.com, kfting@nuvoton.com, den@openvz.org, elena.ufimtseva@oracle.com, jag.raman@oracle.com, daniel.barboza@oss.qualcomm.com, philmd@oss.qualcomm.com, pierrick.bouvier@oss.qualcomm.com, phil@philjordan.eu, tangtao1634@phytium.com.cn, chao.liu@processmission.com, jiri@resnulli.us, sam@rfc1149.net, anisa.su@samsung.com, alex@shazbot.org, farosas@suse.de, mohamed@unpredictable.fr, kvm@vger.kernel.org, linux-cxl@vger.kernel.org, alistair.francis@wdc.com, anthony@xenproject.org, jamin_lin@aspeedtech.com, kane_chen@aspeedtech.com, palmer@dabbelt.com, rbolshakov@ddn.com, foss@defmacro.it, sebastian.huber@embedded-brains.de, fam@euphon.net, jiaxun.yang@flygoat.com, lizhijian@fujitsu.com, atar4qemu@gmail.com, edgar.iglesias@gmail.com, jasowangio@gmail.com, liwei1518@gmail.com, npiggin@gmail.com, zhangckid@gmail.com, titusr@google.com, wuhaotsh@google.com, arei.gonglei@huawei.com, berto@igalia.com, mark.cave-ayland@ilande.co.uk, junjie.cao@intel.com, zhao1.liu@intel.com, its@irrelevant.dk, clg@kaod.org, conor@kernel.org, david@kernel.org, jic23@kernel.org, kbusch@kernel.org, mchehab+huawei@kernel.org, sstabellini@kernel.org, peter.maydell@linaro.org, richard.henderson@linaro.org, zhiwei_liu@linux.alibaba.com, zhenwei.pi@linux.dev, adityag@linux.ibm.com, alifm@linux.ibm.com, amachhiw@linux.ibm.com, borntraeger@linux.ibm.com, brueckner@linux.ibm.com, farman@linux.ibm.com, harshpb@linux.ibm.com, iii@linux.ibm.com, jjherne@linux.ibm.com, milesg@linux.ibm.com, mjrosato@linux.ibm.com Resent-From: Markus Armbruster Resent-Date: Sun, 01 Nov 2026 21:12:17 +0100 Resent-Message-ID: <87a4ns1fby.fsf@pond.sub.org> From: Markus Armbruster To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: qemu-devel@nongnu.org, Michael Roth , John Snow , Peter Maydell , Mauro Carvalho Chehab , Pierrick Bouvier , Paolo Bonzini , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Kostiantyn Kostiuk , Eric Blake , David Hildenbrand , Igor Mammedov , "Edgar E. Iglesias" , Jason Wang , Marcelo Tosatti , kvm@vger.kernel.org, Alberto Garcia , Kevin Wolf , Hanna Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Zhao Liu , Jonathan Cameron , Junjie Cao , Anisa Su , Elena Ufimtseva , Jagannathan Raman , John Levon , Thanos Makatos , =?utf-8?Q?C=C3=A9dric?= Le Goater , Cornelia Huck , Eric Farman , Matthew Rosato , Richard Henderson , Ilya Leoshkevich , qemu-block@nongnu.org, linux-cxl@vger.kernel.org, qemu-s390x@nongnu.org, "Michael S. Tsirkin" , Sergio Lopez , qemu-arm@nongnu.org, Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Chao Liu , qemu-riscv@nongnu.org, Song Gao <17746591750@163.com>, Bibo Mao , Xianglai Li , Jiaxun Yang , Pedro Barbuda , Mohamed Mediouni , Nicholas Piggin , Harsh Prateek Bora , Amit Machhiwal , qemu-ppc@nongnu.org, Zhang Chen , Li Zhijian , Alistair Francis , Alexander Graf , "Gonglei (Arei)" , zhenwei pi , Ani Sinha , Luc Michel , =?utf-8?Q?C=C3=A9dric?= Le Goater , Jamin Lin , Kane Chen , Samuel Tardieu , "Denis V. Lunev" , FangSheng Huang , Tyrone Ting , Hao Wu , Keith Busch , Klaus Jensen , Jesper Devantier , Aditya Gupta , Glenn Miles , Conor Dooley , Sebastian Huber , Halil Pasic , Christian Borntraeger , Jason Herne , Titus Rwantare , Stefano Stabellini , Anthony PERARD , Peter Xu , Chinmay Rath , Hendrik Brueckner , xen-devel@lists.xenproject.org, Roman Bolshakov , Phil Dennis-Jordan , Fam Zheng , Farhan Ali , Alex Williamson , Tao Tang , Stefan Berger , Fabiano Rosas , Mark Cave-Ayland , Artyom Tarasenko , Yoshinori Sato , Jiri Pirko , Eric Auger , Laurent Vivier Subject: Re: [PATCH v7 64/65] qom: use QAPITypeInfo in object_property_get_enum In-Reply-To: <20261020-qom-qapi-v7-64-431a86b02b58@redhat.com> (=?utf-8?Q?=22Marc-Andr=C3=A9?= Lureau"'s message of "Tue, 20 Oct 2026 14:46:21 +0400") References: <20261020-qom-qapi-v7-0-431a86b02b58@redhat.com> <20261020-qom-qapi-v7-64-431a86b02b58@redhat.com> Date: Sun, 01 Nov 2026 17:15:34 +0100 Message-ID: <87mrrs7ck9.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Marc-Andr=C3=A9 Lureau writes: > The typename parameter becomes a QAPITypeInfo pointer, and the > validation compares prop->qapi_type against it instead of matching > prop->type strings. > > Signed-off-by: Markus Armbruster > Signed-off-by: Marc-Andr=C3=A9 Lureau [...] > diff --git a/qom/object.c b/qom/object.c > index 791d981dc689..40b569d4d574 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -1775,7 +1775,7 @@ uint64_t object_property_get_uint(Object *obj, cons= t char *name, > } >=20=20 > int object_property_get_enum(Object *obj, const char *name, > - const char *typename, Error **errp) > + const QAPITypeInfo *type_info, Error **errp) > { > char *str; > int ret; > @@ -1785,10 +1785,10 @@ int object_property_get_enum(Object *obj, const c= har *name, > return -1; > } >=20=20 > - if (!g_str_equal(prop->type, typename)) { > + if (prop->qapi_type !=3D type_info) { > error_setg(errp, "Property %s on %s is not '%s' enum type", > - name, object_class_get_name( > - object_get_class(obj)), typename); > + name, object_class_get_name(object_get_class(obj)), > + type_info->name); How can this happen? Or is it a programming error? > return -1; > } >=20=20 [...]