Re: [PATCH 1/6] dmaengine: idxd: Do not call destroy_workqueue with null idxd->wq

[Vinicius Costa Gomes <vinicius.gomes@intel.com>]

Dave Jiang <dave.jiang@intel.com> writes:

> On 10/12/26 2:38 PM, Vinicius Costa Gomes wrote:
>> From: Steve Wahl <steve.wahl@hpe.com>
>> 
>> Error paths within idxd_pci_probe_alloc and related functions end up
>> calling destroy_workqueue with a null pointer, from
>> idxd_conf_device_release via put_device, because that allocation has
>> not yet occurred when the error is hit.
>> 
>> This was encountered running in a kexec'd kdump kernel with reduced
>> resources, causing the "Device is HALTED!" branch in
>> idxd_device_init_reset to be taken.
>> 
>> In idxd_conf_device_release, check that the workqueue has been
>> allocated before trying to destroy it.
>> 
>> Fixes: 3d33de353b1f ("dmaengine: idxd: Fix not releasing workqueue on .release()")
>> Signed-off-by: Steve Wahl <steve.wahl@hpe.com>
>> Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
> ^ needs a sign off rather than an ack since you posted his patch?
>

Yeah, will add my sign off. 


Cheers,
-- 
Vinicius