All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rasmus Villemoes <rv@rasmusvillemoes.dk>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: u-boot@lists.u-boot-project.org,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Héctor Orón Martínez" <zumbi@debian.org>,
	"Mattia Maldini" <mattia512maldini@gmail.com>,
	"Simon Glass" <sjg@chromium.org>, "Tom Rini" <trini@konsulko.com>,
	"Vagrant Cascadian" <vagrant@debian.org>
Subject: Re: [PATCH 1/2] kbuild: Pass -Eno-node_name_not_empty to DTC if supported
Date: Mon, 05 Oct 2026 08:44:23 +0200	[thread overview]
Message-ID: <87mrsspry0.fsf@prevas.dk> (raw)
In-Reply-To: <20261004061826.1028380-1-marek.vasut+renesas@mailbox.org>

On Sun, Oct 04 2026, Marek Vasut <marek.vasut+renesas@mailbox.org> wrote:

> Since DTC 7c78c8542d73 ("Added empty node name check") , U-Boot binman
> use of placeholder node names such as @fdt-SEQ and @config-SEQ triggers
> DTC ERROR (node_name_not_empty). Inhibit the error, as these placeholder
> nodes are updated by binman and replaced by proper nodes, the encoding
> in DTB is temporary. Since -Eno-node_name_not_empty is only available in
> DTC 1.8.0 and newer, introduce "dtc-option" make function which is very
> similar to "cc-option" and other such Kbuild functions, and add the DTC
> option conditionally.

Is this the best way to handle this? This also removes the error for
empty node names that might appear in the "real" part of the dtb, no?

I'm not really familiar with the binman magic, but is there any reason
those placeholder nodes cannot be binman@fdt-SEQ and binman@config-SEQ,
or anything like that? Sure, the binman code would need updating and
there would be some -u-boot.dtsi files to update, but I'm currently
counting less than 70 instances, about half in tests, so it would not be
a lot of churn, and changing it now would mean we avoid having to carry
around that dtc flag forever.

Rasmus

      parent reply	other threads:[~2026-10-05  6:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-04  6:17 [PATCH 1/2] kbuild: Pass -Eno-node_name_not_empty to DTC if supported Marek Vasut
2026-10-04  6:17 ` [PATCH 2/2] kbuild: Do not pass -Wno-graph_child_address to DTC unless supported Marek Vasut
2026-10-05 20:59   ` Tom Rini
2026-10-05  6:44 ` Rasmus Villemoes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mrsspry0.fsf@prevas.dk \
    --to=rv@rasmusvillemoes.dk \
    --cc=david@gibson.dropbear.id.au \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=mattia512maldini@gmail.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=vagrant@debian.org \
    --cc=zumbi@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.