From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>
Cc: "Sergey Senozhatsky" <senozhatsky@chromium.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Marcos Paulo de Souza" <mpdesouza@suse.com>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Fushuai Wang" <wangfushuai@baidu.com>,
"Kees Cook" <kees@kernel.org>,
"Stepan Ionichev" <sozdayvek@gmail.com>,
linux-serial@vger.kernel.org,
"Manuel Lauss" <manuel.lauss@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] braille: nbcon: Allow to use a serial console with NBCON API as Braille console
Date: Fri, 02 Oct 2026 11:19:53 +0206 [thread overview]
Message-ID: <87mrswwjla.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <ar9wacP7FGkiKFXp@pathway.suse.cz>
On 2026-10-02, Petr Mladek <pmladek@suse.com> wrote:
> It should be good enough for 7.3. And I wanted to get it into
> linux-next ASAP.
>
> There is still an open problem with the dependency on CONFIG_PRINTK
> to fix the Sashiko complains. We might add it as a separate patch.
> But we might also try to fix it properly by enabling nbcon.c code
> even when CONFIG_PRINTK is disabled, ...
It would probably be enough just to set the !CONFIG_PRINTK case to:
static inline bool nbcon_braille_try_acquire(struct console *con,
struct nbcon_write_context *wctxt) { return true; }
Since there is no PRINTK, there will be no consoles to synchronize
against.
Or in drivers/accessibility/braille/braille_console.c you could change
all the
panic_on_this_cpu()
checks to
IS_ENABLED(CONFIG_PRINTK) && panic_on_this_cpu()
John
prev parent reply other threads:[~2026-10-02 9:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 14:07 [PATCH v4 0/1] braille: nbcon: Fix Braille console for NBCON API Petr Mladek
2026-10-01 14:07 ` [PATCH v4 1/1] braille: nbcon: Allow to use a serial console with NBCON API as Braille console Petr Mladek
2026-10-01 14:24 ` sashiko-bot
2026-10-02 8:14 ` Petr Mladek
2026-10-01 15:32 ` John Ogness
2026-10-02 8:50 ` Petr Mladek
2026-10-02 9:13 ` John Ogness [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrswwjla.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=mpdesouza@suse.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=senozhatsky@chromium.org \
--cc=sozdayvek@gmail.com \
--cc=wangfushuai@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.