All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: alex.aring@gmail.com,  andrew+netdev@lunn.ch,
	 davem@davemloft.net, edumazet@google.com,  kuba@kernel.org,
	 linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org,
	 marcel@holtmann.org, netdev@vger.kernel.org,  pabeni@redhat.com,
	 stefan@datenfreihafen.org, stable@vger.kernel.org
Subject: Re: [PATCH] ieee802154: atusb: Fix URB reference leak in atusb_work_urbs()
Date: Sat, 19 Sep 2026 09:46:06 +0200	[thread overview]
Message-ID: <87mrtdela9.fsf@bootlin.com> (raw)
In-Reply-To: <20260917114821.2149704-1-vulab@iscas.ac.cn> (Wentao Liang's message of "Thu, 17 Sep 2026 11:48:21 +0000")


> usb_get_from_anchor() hands over a reference to the URB, which the caller
> has to release. atusb_work_urbs() never does, so every URB collected from
> the idle anchor keeps an extra reference: the reference count grows on
> each retry cycle and the URBs are never freed on disconnect. Drop the
> reference after a successful submission, and after the URB has been put
> back on the idle anchor when submission failed, as the HCD holds its own
> reference while the URB is in flight.
>
> Fixes: 7490b008d123 ("ieee802154: add support for atusb transceiver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

  reply	other threads:[~2026-09-19  7:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 11:48 [PATCH] ieee802154: atusb: Fix URB reference leak in atusb_work_urbs() Wentao Liang
2026-09-19  7:46 ` Miquel Raynal [this message]
2026-09-21 15:14 ` krzk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mrtdela9.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alex.aring@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=stefan@datenfreihafen.org \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.