Re: [PATCH v2 00/18] migration: MigrationParameters changes

[Fabiano Rosas <farosas@suse.de>]

Peter Xu <peterx@redhat.com> writes:

> On Wed, Sep 09, 2026 at 06:44:50PM -0300, Fabiano Rosas wrote:
>> Fabiano Rosas (18):
>>   checkpatch: Fix checking of newlines in error messages
>>   migration/options.c: Don't export migrate_tls_opts_free
>>   migration: Rename variables in qmp_migrate_set_parameters
>>   migration: Use QAPI_CLONE_MEMBERS in migrate_params_apply
>>   migration: Merge parameter structs instead of assigning one by one
>>   migration: Open code migrate_params_apply
>>   migration: Stop freeing s->parameters members individually
>>   migration: Use migrate_params_free during finalize
>>   tests/qtest/migration: Add a test for HMP
>>   tests/qtest/migration: Add a test for HMP completion
>>   migration: HMP: Fix bandwidth parameters
>>   migration: Change HMP 'info migrate_parameters' output
>>   migration: Use keyval input visitor in HMP set command
>>   migration: Use output visitor in info command
>>   migration: Rewrite migrate_set_parameter_completion using QDict
>>   migration: Add capabilities into MigrationParameters
>>   migration: Remove s->capabilities
>>   qapi/migration: Deprecate capabilities commands
>
> The new HMP test may fail when ran without userfaultfd privilege.
>
> $ QTEST_QEMU_BINARY=./qemu-system-x86_64 ./tests/qtest/migration-test --full -r /x86_64/migration/hmp
> TAP version 14
> # random seed: R02S0ff0d2920ac5e3bffdb3b5a776110e91
> # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-219499.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-219499.qmp,id=char0 -object monitor-qmp,id=qmp0,chardev=char0 -display none -audio none -run-with exit-with-parent=on -machine none  -accel qtest
> # Skipping test: userfaultfd not available
> # Start of x86_64 tests
> # Start of migration tests
> # Start of hmp tests
> # Running /x86_64/migration/hmp/parameters
> # starting QEMU: exec ./qemu-system-x86_64 -qtest unix:/tmp/qtest-219499.sock -qtest-log /dev/null -chardev socket,path=/tmp/qtest-219499.qmp,id=char0 -object monitor-qmp,id=qmp0,chardev=char0 -display none -audio none -run-with exit-with-parent=on -accel tcg -nodefaults -S  -accel qtest
> # HMP command failed:
> # 
> # Error: Background-snapshot is not supported by host kernel
> # 
> **
> ERROR:../tests/qtest/migration/misc-tests.c:376:assert_hmp_success: code should not be reached
> not ok /x86_64/migration/hmp/parameters - ERROR:../tests/qtest/migration/misc-tests.c:376:assert_hmp_success: code should not be reached
> Bail out!
> Aborted                    (core dumped) QTEST_QEMU_BINARY=./qemu-system-x86_64 ./tests/qtest/migration-test --full -r /x86_64/migration/hmp
>
> We can either fix it (but I don't see easy way to wrap some TESTs to run
> conditionally), or drop the verifications for background-snapshot cap for
> now.

Thank you for testing this. I think I can just move the array into the
test function and check env->has_uffd in there.