From: Takashi Iwai <tiwai@suse.de>
To: Zhang Heng <zhangheng@kylinos.cn>
Cc: tiwai@suse.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Drop duplicate quirk for Lenovo 0x17aa:0x38df
Date: Fri, 14 Aug 2026 10:44:11 +0200 [thread overview]
Message-ID: <87mrupdrc4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260814084101.504471-1-zhangheng@kylinos.cn>
On Fri, 14 Aug 2026 10:41:01 +0200,
Zhang Heng wrote:
>
> The PCI SSID 17aa:38df is listed twice in alc269_fixup_tbl[], both mapping
> to the same fixup ALC287_FIXUP_TAS2781_I2C:
>
> SND_PCI_QUIRK(0x17aa, 0x38df, "Yoga Y990 Intel YC Dual", ALC287_FIXUP_TAS2781_I2C),
> ...
> SND_PCI_QUIRK(0x17aa, 0x38df, "Y990 YG DUAL", ALC287_FIXUP_TAS2781_I2C),
>
> The HDA quirk lookup (hda_quirk_lookup_id()) returns the first matching
> entry, so the second occurrence never takes effect; it is dead code.
>
> Drop the second entry. The retained "Yoga Y990 Intel YC Dual" label also
> follows the naming of the neighbouring 0x38e0 entry ("Yoga Y990 Intel VECO
> Dual").
>
> Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-08-14 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 8:41 [PATCH] ALSA: hda/realtek: Drop duplicate quirk for Lenovo 0x17aa:0x38df Zhang Heng
2026-08-14 8:44 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrupdrc4.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=zhangheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.