From: Takashi Iwai <tiwai@suse.de>
To: songxiebing <songxiebing@kylinos.cn>
Cc: tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: simplify match functions and remove unreachable return
Date: Wed, 12 Aug 2026 07:29:55 +0200 [thread overview]
Message-ID: <87mrur29f0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260812033007.633564-1-songxiebing@kylinos.cn>
On Wed, 12 Aug 2026 05:30:07 +0200,
songxiebing wrote:
>
> From: Bob Song <songxiebing@kylinos.cn>
>
> hda_bus_match() has an unreachable 'return 1' after an if/else that
> covers both branches. Remove the superfluous return and simplify the
> control flow by dropping the else branch.
>
> hdac_codec_match() uses a redundant if/else to return 1 or 0.
> Simplify to a single return statement.
>
> Signed-off-by: Bob Song <songxiebing@kylinos.cn>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-08-12 5:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 3:30 [PATCH] ALSA: hda: simplify match functions and remove unreachable return songxiebing
2026-08-12 5:29 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrur29f0.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=songxiebing@kylinos.cn \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.