From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54C9FC54F4C for ; Tue, 28 Jul 2026 14:04:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1woiPU-0003gZ-D2; Tue, 28 Jul 2026 10:03:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1woiPS-0003fl-Nl for qemu-trivial@nongnu.org; Tue, 28 Jul 2026 10:03:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1woiPR-0002fe-7a for qemu-trivial@nongnu.org; Tue, 28 Jul 2026 10:03:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785247432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZTcUYJR3ZkqlI+K293x1cuKvm9R4enTMB4xoVxh0vgg=; b=Q0r6vuQ/eL53wzwRW2/WVvAT5c50im6MJrCA3fnTpgjEw+6NQ6rEzGAVii5zH/EXy+8Ar6 bDLJ578lTXd+eO8ifxG82BqyDVqNl8rvu4myFgHiIMNbq1qYLOdhfk4p5WUa7HEmIKzbPw 7vkYy9Bg1dlSP2dt3wfNz6YHfnxcfzk= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-JnQILyFeNDG833Mv4P6lVw-1; Tue, 28 Jul 2026 10:03:47 -0400 X-MC-Unique: JnQILyFeNDG833Mv4P6lVw-1 X-Mimecast-MFC-AGG-ID: JnQILyFeNDG833Mv4P6lVw_1785247423 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CE94019560BE; Tue, 28 Jul 2026 14:03:42 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.44.22.4]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D4DF21800480; Tue, 28 Jul 2026 14:03:40 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 6D74D21E6920; Tue, 28 Jul 2026 16:03:38 +0200 (CEST) From: Markus Armbruster To: John Snow Cc: Markus Armbruster , qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Lukas Straub , Vladimir Sementsov-Ogievskiy , Zhao Liu , Laurent Vivier , "Gonglei (Arei)" , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Alex Williamson , zhenwei pi , Hanna Reitz , Ani Sinha , qemu-block@nongnu.org, Paolo Bonzini , Peter Xu , Kevin Wolf , linux-cxl@vger.kernel.org, Jiri Pirko , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Stefan Berger , Fabiano Rosas , Stefan Hajnoczi , Michael Tokarev , Igor Mammedov , "Michael S. Tsirkin" , Gerd Hoffmann , Mauro Carvalho Chehab , linux-edac@vger.kernel.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Richard Henderson , Eric Blake , =?utf-8?Q?C=C3=A9dric?= Le Goater , Jason Wang , qemu-trivial@nongnu.org, Jonathan Cameron Subject: Re: [PATCH v2 00/44] qapi: convert trivial intro sections In-Reply-To: (John Snow's message of "Mon, 27 Jul 2026 13:16:13 -0400") References: <20260723044805.527643-1-jsnow@redhat.com> <87ik65g8xm.fsf@pond.sub.org> <87h5lobypc.fsf@pond.sub.org> Date: Tue, 28 Jul 2026 16:03:38 +0200 Message-ID: <87mrvbtdmt.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-MFC-PROC-ID: cCo2AeO3nuh-fbla2elIHD8y_wfuPzuPHfYaDANonnk_1785247423 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Sender: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org John Snow writes: > On Fri, Jul 24, 2026 at 4:04=E2=80=AFAM Markus Armbruster wrote: >> >> Markus Armbruster writes: >> >> [...] >> >> > Converting single first paragraps is mechanical. For it to be correct= , >> > this single paragraph must actually be the overview, and not some othe= r >> > crap. I expect it to be almost always overview. Not sure how to best >> > look for the exceptions. >> >> The separation truly matters only when the inliner inlines the doc >> comment. It potentially matters when it would inline it if the type was >> used differently. > > It also (potentially) matters for auto-generated docs, such as > undocumented members, return types, features*, errors*. The break > point is where these fields get inserted. Right, I forgot about this. There goes my review shortcut... > (*Not currently performed. Not asserting that it will be performed, or > that it is necessarily valuable to do so. Just fleshing out the > category.) > >> >> If I remember correctly, the inliner inlines doc of struct / union base >> type, union branch type, command / event argument type. >> >> Argument can only be struct or union. Base and branch can only be >> struct. >> >> We talked about maybe inlining return types some day. This would be >> struct, union, or array of struct or union. >> >> So, for anything other than struct and union, the inliner doesn't get >> involved, and separating the overview cleanly is just a matter of >> writing style. I'm not sure we care. Even if we elect to care, >> cleaning it up is hardly this series' business. In short, your >> mechanical conversion of single first paragraphs to overview syntax >> should be fine even where a paragraph's contents isn't clearly overview. > > Except in cases where stub positioning matters, see also the former > "TODO:" syntax used to delineate intro/details. > >> >> Structs and unions, however, could use an eye-over. >> >> [...] >>