Re: [PATCH] drm/xe/xe3p_lpg: Add missing references to workarounds

[Gustavo Sousa <gustavo.sousa@intel.com>]

Matt Roper <matthew.d.roper@intel.com> writes:

> On Wed, Jun 10, 2026 at 06:20:47PM -0300, Gustavo Sousa wrote:
>> Sometimes the same workaround implementation ends up being the
>> recommended fix different hardware issues, which are tracked by
>> different workaround lineage numbers.
>> 
>> Some of the Xe3p_LPG workarounds got "dismissed" because the
>> implementations were already in the driver, however for a different
>> lineage number.
>> 
>> Even though the implementation for workaround #A is already present in
>> the driver for workaround #B, it is still important to reference #A in
>> the driver for tracking purposes.  Without such a reference, we risk
>> dropping the workaround implementation if, for some reason in the
>> future, we decide that #B is not necessary anymore while #A is still
>> required.
>> 
>> As such, add the missing references for Xe3p_LPG.
>> 
>> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

Applied to drm-xe-next. Thanks for the review!

--
Gustavo Sousa

>
>> ---
>> Note: I realized this while reviewing the workaround database for
>> Xe3p_LPG against our current driver code.  There could be more cases
>> for other IPs.
>> ---
>>  drivers/gpu/drm/xe/xe_wa.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
>> index 635d5461f712..139434946f8f 100644
>> --- a/drivers/gpu/drm/xe/xe_wa.c
>> +++ b/drivers/gpu/drm/xe/xe_wa.c
>> @@ -293,7 +293,7 @@ VISIBLE_IF_KUNIT const struct xe_rtp_table_sr gt_was = XE_RTP_TABLE_SR(
>>  	  XE_RTP_ACTIONS(SET(MMIOATSREQLIMIT_GAM_WALK_3D,
>>  			     DIS_ATS_WRONLY_PG))
>>  	},
>> -	{ XE_RTP_NAME("14026144927, 16029437861"),
>> +	{ XE_RTP_NAME("14026144927, 16029437861, 14026127056"),
>>  	  XE_RTP_RULES(GRAPHICS_VERSION(3510), GRAPHICS_STEP(A0, B0)),
>>  	  XE_RTP_ACTIONS(SET(L3SQCREG2, L3_SQ_DISABLE_COAMA_2WAY_COH |
>>  			     L3_SQ_DISABLE_COAMA))
>> @@ -587,12 +587,12 @@ static const struct xe_rtp_table_sr engine_was = XE_RTP_TABLE_SR(
>>  
>>  	/* Xe3p_LPG*/
>>  
>> -	{ XE_RTP_NAME("22021149932"),
>> +	{ XE_RTP_NAME("22021149932, 14026290593"),
>>  	  XE_RTP_RULES(GRAPHICS_VERSION(3510), GRAPHICS_STEP(A0, B0),
>>  		       FUNC(xe_rtp_match_first_render_or_compute)),
>>  	  XE_RTP_ACTIONS(SET(LSC_CHICKEN_BIT_0_UDW, SAMPLER_LD_LSC_DISABLE))
>>  	},
>> -	{ XE_RTP_NAME("14025676848"),
>> +	{ XE_RTP_NAME("14025676848, 14026270459"),
>>  	  XE_RTP_RULES(GRAPHICS_VERSION(3510), GRAPHICS_STEP(A0, B0),
>>  		       FUNC(xe_rtp_match_first_render_or_compute)),
>>  	  XE_RTP_ACTIONS(SET(LSC_CHICKEN_BIT_0_UDW, LSCFE_SAME_ADDRESS_ATOMICS_COALESCING_DISABLE))
>> 
>> ---
>> base-commit: 10db0c83b0ccc3211990b54235475abb9d383851
>> change-id: 20260610-add-missing-wa-references-c58331fb7e55
>> 
>> Best regards,
>> --  
>> Gustavo Sousa <gustavo.sousa@intel.com>
>> 
>
> -- 
> Matt Roper
> Graphics Software Engineer
> Linux GPU Platform Enablement
> Intel Corporation