From: Mattijs Korpershoek <mkorpershoek@kernel.org>
To: Marek Vasut <marek.vasut@mailbox.org>,
Balaji Selvanathan <balaji.selvanathan@oss.qualcomm.com>,
u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>, Tom Rini <trini@konsulko.com>,
Mattijs Korpershoek <mkorpershoek@kernel.org>,
Jonas Karlman <jonas@kwiboo.se>,
Kever Yang <kever.yang@rock-chips.com>,
Casey Connolly <casey.connolly@linaro.org>,
Kaustabh Chakraborty <kauschluss@disroot.org>,
Sam Protsenko <semen.protsenko@linaro.org>
Subject: Re: [PATCH] dwc3: Fix fastboot re-run failure with flat DTS
Date: Mon, 08 Jun 2026 09:15:13 +0200 [thread overview]
Message-ID: <87mrx5zeny.fsf@kernel.org> (raw)
In-Reply-To: <a6c838a3-f795-4a29-bb0e-89a8b8fb098b@mailbox.org>
Hi,
On Sat, May 30, 2026 at 12:02, Marek Vasut <marek.vasut@mailbox.org> wrote:
> On 5/29/26 2:22 PM, Balaji Selvanathan wrote:
>> Problem: The first "run fastboot" works and enumerates on the host.
>> Subsequent runs fail, with no USB enumeration observed.
>>
>> With flat DTS configurations, the peripheral device inherits
>> power-domains from its parent (glue) node, as both reference the
>> same DT node. During teardown after "fastboot continue",
>> device_remove() of peripheral device invokes dev_power_domain_off(),
>> which powers off the shared USB GDSC.
>>
>> As a result, the next "run fastboot" fails because the power
>> domain is left in an uninitialized state.
>>
>> Add DM_FLAG_LEAVE_PD_ON to dwc3_generic_peripheral to prevent
>> power domain shutdown during peripheral removal.
> It seems the driver does not handle its power domains correctly,
> inhibiting PD control is not a fix, sorry.
I agree with Marek here. Especially since this is a generic driver.
I had a somewhat similar problem on amlogic devices where I could only
run fastboot once.
I've solved this via
https://lore.kernel.org/all/20221024-meson-dm-usb-v1-1-2ab077a503b9@baylibre.com/
Maybe you can explore something similar instead?
next prev parent reply other threads:[~2026-06-08 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 12:22 [PATCH] dwc3: Fix fastboot re-run failure with flat DTS Balaji Selvanathan
2026-05-30 10:02 ` Marek Vasut
2026-06-08 7:15 ` Mattijs Korpershoek [this message]
2026-06-08 9:07 ` Balaji Selvanathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mrx5zeny.fsf@kernel.org \
--to=mkorpershoek@kernel.org \
--cc=balaji.selvanathan@oss.qualcomm.com \
--cc=casey.connolly@linaro.org \
--cc=jonas@kwiboo.se \
--cc=kauschluss@disroot.org \
--cc=kever.yang@rock-chips.com \
--cc=marek.vasut@mailbox.org \
--cc=marex@denx.de \
--cc=semen.protsenko@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.