From: Cornelia Huck <cohuck@redhat.com>
To: Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, eric.auger@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
peter.maydell@linaro.org, maz@kernel.org, oliver.upton@linux.dev,
sebott@redhat.com, gshan@redhat.com, ddutile@redhat.com,
peterx@redhat.com, philmd@linaro.org, pbonzini@redhat.com
Subject: Re: [PATCH v3 03/11] target/arm/cpu: Allow registers to be hidden
Date: Tue, 25 Nov 2025 18:04:38 +0100 [thread overview]
Message-ID: <87ms4aoxg9.fsf@redhat.com> (raw)
In-Reply-To: <20251125100859.506228-4-eric.auger@redhat.com>
On Tue, Nov 25 2025, Eric Auger <eric.auger@redhat.com> wrote:
> More recent kernels sometimes expose new registers in an
> unconditionnal manner. This situation breaks backward migration
> as qemu notices there are more registers in the input stream
> than supported on the destination host. This leads to a
> "failed to load cpu:cpreg_vmstate_array_len" error.
>
> A good example is the introduction of KVM_REG_ARM_VENDOR_HYP_BMAP_2
> pseudo FW register in v6.16 by commit C0000e58c74e (“KVM: arm64:
> Introduce KVM_REG_ARM_VENDOR_HYP_BMAP_2”). Trying to do backward
> migration from a host kernel that features the commit to a destination
> host that doesn't, fail with above error.
>
> Currently QEMU is not using that feature so ignoring this latter
> is not a problem. An easy way to fix the migration issue is to teach
> qemu we don't care about that register and we can simply ignore it
> when syncing its state during migration.
>
> This patch introduces an array of such hidden registers. Soon it will
> be settable through an array property.
>
> If hidden, the register is moved out of the array of cpreg which is
> built in kvm_arm_init_cpreg_list(). That way their state won't be
> synced.
I'm wondering whether the patch description should also mention non-KVM
cases (e.g. the bogus reg that was exposed). It might also make sense to
merge patch 5 here?
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
Otherwise, LGTM.
next prev parent reply other threads:[~2025-11-25 17:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 10:07 [PATCH v3 00/11] Mitigation of "failed to load cpu:cpreg_vmstate_array_len" migration failures Eric Auger
2025-11-25 10:07 ` [PATCH v3 01/11] hw/arm/virt: Rename arm_virtio_compat into arm_virt_compat_defaults Eric Auger
2025-11-25 16:42 ` Cornelia Huck
2025-11-26 15:30 ` Sebastian Ott
2025-11-26 16:29 ` Sebastian Ott
2025-11-25 10:07 ` [PATCH v3 02/11] target/arm/machine: Improve traces on register mismatch during migration Eric Auger
2025-11-25 10:07 ` [PATCH v3 03/11] target/arm/cpu: Allow registers to be hidden Eric Auger
2025-11-25 17:04 ` Cornelia Huck [this message]
2025-12-22 13:17 ` Eric Auger
2025-12-22 13:21 ` Eric Auger
2025-11-26 16:28 ` Sebastian Ott
2025-11-25 10:07 ` [PATCH v3 04/11] target/arm/machine: Allow extra regs in the incoming stream Eric Auger
2025-11-25 17:07 ` Cornelia Huck
2025-11-25 10:07 ` [PATCH v3 05/11] target/arm/helper: Skip hidden registers Eric Auger
2025-11-25 10:07 ` [PATCH v3 06/11] kvm-all: Add the capability to blacklist some KVM regs Eric Auger
2025-11-25 17:09 ` Cornelia Huck
2025-11-26 16:42 ` Sebastian Ott
2025-11-25 10:07 ` [PATCH v3 07/11] target/arm/cpu: Implement hide_reg callback() Eric Auger
2025-11-25 17:10 ` Cornelia Huck
2025-11-26 16:55 ` Sebastian Ott
2025-11-25 10:07 ` [PATCH v3 08/11] target/arm/cpu: Expose x-mig-hidden-regs and x-mig-safe-missing-regs properties Eric Auger
2025-11-25 17:17 ` Cornelia Huck
2025-11-25 10:07 ` [PATCH v3 09/11] hw/arm/virt: Declare AArch32 DBGDTRTX as safe to ignore in incoming stream Eric Auger
2025-11-25 17:20 ` Cornelia Huck
2025-11-25 10:07 ` [PATCH v3 10/11] Revert "target/arm: Reinstate bogus AArch32 DBGDTRTX register for migration compat" Eric Auger
2025-11-25 10:08 ` [PATCH v3 11/11] hw/arm/virt: [DO NOT UPSTREAM] Enforce compatibility with older kernels Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms4aoxg9.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=ddutile@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=gshan@redhat.com \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sebott@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.