From: Jakub Sitnicki <jakub@cloudflare.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, kernel-team@cloudflare.com
Subject: Re: [PATCH net-next v3 3/3] selftests/net: Cover port sharing scenarios with IP_LOCAL_PORT_RANGE
Date: Thu, 17 Jul 2025 11:44:25 +0200 [thread overview]
Message-ID: <87ms93dudi.fsf@cloudflare.com> (raw)
In-Reply-To: <4688d857-0cdf-4f39-99de-c3bfc7abd3d6@redhat.com> (Paolo Abeni's message of "Thu, 17 Jul 2025 11:27:41 +0200")
On Thu, Jul 17, 2025 at 11:27 AM +02, Paolo Abeni wrote:
> On 7/14/25 6:03 PM, Jakub Sitnicki wrote:
>> diff --git a/tools/testing/selftests/net/ip_local_port_range.sh b/tools/testing/selftests/net/ip_local_port_range.sh
>> index 4ff746db1256..3fc151545b2d 100755
>> --- a/tools/testing/selftests/net/ip_local_port_range.sh
>> +++ b/tools/testing/selftests/net/ip_local_port_range.sh
>> @@ -1,7 +1,11 @@
>> -#!/bin/sh
>> +#!/bin/bash
>> # SPDX-License-Identifier: GPL-2.0
>>
>> -./in_netns.sh \
>> - sh -c 'sysctl -q -w net.mptcp.enabled=1 && \
>> - sysctl -q -w net.ipv4.ip_local_port_range="40000 49999" && \
>> - ./ip_local_port_range'
>> +./in_netns.sh sh <(cat <<-EOF
>> + sysctl -q -w net.mptcp.enabled=1
>> + sysctl -q -w net.ipv4.ip_local_port_range="40000 49999"
>> + ip -6 addr add dev lo 2001:db8::1/32 nodad
>> + ip -6 addr add dev lo 2001:db8::2/32 nodad
>> + exec ./ip_local_port_range
>
> Minor nit: it looks like you could simply add the additional statements
> to the '-c' argument without changing the used shell.
I might have gone overboard here. Will revert.
next prev parent reply other threads:[~2025-07-17 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 16:03 [PATCH net-next v3 0/3] tcp: Consider every port when connecting with IP_LOCAL_PORT_RANGE Jakub Sitnicki
2025-07-14 16:03 ` [PATCH net-next v3 1/3] tcp: Add RCU management to inet_bind2_bucket Jakub Sitnicki
2025-07-14 16:03 ` [PATCH net-next v3 2/3] tcp: Consider every port when connecting with IP_LOCAL_PORT_RANGE Jakub Sitnicki
2025-07-17 9:23 ` Paolo Abeni
2025-07-17 9:44 ` Jakub Sitnicki
2025-07-17 11:21 ` Jakub Sitnicki
2025-07-14 16:03 ` [PATCH net-next v3 3/3] selftests/net: Cover port sharing scenarios " Jakub Sitnicki
2025-07-17 9:27 ` Paolo Abeni
2025-07-17 9:44 ` Jakub Sitnicki [this message]
2025-07-17 9:34 ` Paolo Abeni
2025-07-17 9:50 ` Jakub Sitnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms93dudi.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.