From: Markus Armbruster <armbru@redhat.com>
To: Steven Sistare <steven.sistare@oracle.com>
Cc: qemu-devel@nongnu.org, John Snow <jsnow@redhat.com>,
Cleber Rosa <crosa@redhat.com>, Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
Fabiano Rosas <farosas@suse.de>,
Laurent Vivier <lvivier@redhat.com>,
Philippe Mathieu-Daude <philmd@linaro.org>
Subject: Re: [PATCH V4 2/3] python: use qom-list-get
Date: Fri, 11 Jul 2025 18:50:04 +0200 [thread overview]
Message-ID: <87ms9au0xv.fsf@pond.sub.org> (raw)
In-Reply-To: <a84a1482-4ba4-4520-b875-9b3a9a879868@oracle.com> (Steven Sistare's message of "Fri, 11 Jul 2025 11:23:03 -0400")
Steven Sistare <steven.sistare@oracle.com> writes:
> On 7/11/2025 10:47 AM, Markus Armbruster wrote:
>> Steve Sistare <steven.sistare@oracle.com> writes:
>>
>>> Use qom-list-get to speed up the qom-tree command.
>>>
>>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>>
>> Quick test... Differences in output before and after match expectations
>> (see appended diff).
>>
>> New version:
>>
>> real 0m0.446s
>> user 0m0.062s
>> sys 0m0.017s
>>
>> Old version barfs a stack backtrace (appended), and is ~18x slower:
>>
>> real 0m8.176s
>> user 0m0.395s
>> sys 0m0.126s
>>
>> Did you see the stack backtrace, too?
>>
>> Regardless
>> Acked-by: Markus Armbruster <armbru@redhat.com>
>
> Thanks. Do you want a tested-by credit, or is that too little testing
> for you to stand behind that endorsement?
Tested-by: Markus Armbruster <armbru@redhat.com>
> I observe the same expected differences.
>
> My test did not backtrace. Must be a different VM.
Let's not worry about it.
[...]
next prev parent reply other threads:[~2025-07-11 16:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 16:24 [PATCH V4 0/3] fast qom tree get Steve Sistare
2025-07-10 16:24 ` [PATCH V4 1/3] qom: qom-list-get Steve Sistare
2025-07-11 14:35 ` Markus Armbruster
2025-07-11 15:22 ` Steven Sistare
2025-07-10 16:24 ` [PATCH V4 2/3] python: use qom-list-get Steve Sistare
2025-07-11 14:47 ` Markus Armbruster
2025-07-11 15:23 ` Steven Sistare
2025-07-11 16:50 ` Markus Armbruster [this message]
2025-07-11 17:08 ` Steven Sistare
2025-07-15 17:27 ` John Snow
2025-07-16 8:32 ` Markus Armbruster
2025-08-07 22:04 ` John Snow
2025-08-08 6:28 ` Markus Armbruster
2025-08-08 16:16 ` John Snow
2025-07-10 16:24 ` [PATCH V4 3/3] tests/qtest/qom-test: unit test for qom-list-getv Steve Sistare
2025-07-11 15:02 ` Markus Armbruster
2025-07-11 15:23 ` Steven Sistare
2025-07-11 15:06 ` [PATCH V4 0/3] fast qom tree get Markus Armbruster
2025-07-11 15:27 ` Steven Sistare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms9au0xv.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=farosas@suse.de \
--cc=jsnow@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.