All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ankur Arora <ankur.a.arora@oracle.com>
To: Raghavendra K T <raghavendra.kt@amd.com>
Cc: Ankur Arora <ankur.a.arora@oracle.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
	akpm@linux-foundation.org, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com,
	mjguzik@gmail.com, luto@kernel.org, peterz@infradead.org,
	acme@kernel.org, namhyung@kernel.org, tglx@linutronix.de,
	willy@infradead.org, jon.grimm@amd.com, bharata@amd.com,
	boris.ostrovsky@oracle.com, konrad.wilk@oracle.com
Subject: Re: [PATCH v4 00/13] x86/mm: Add multi-page clearing
Date: Mon, 07 Jul 2025 14:02:47 -0700	[thread overview]
Message-ID: <87ms9fr9xk.fsf@oracle.com> (raw)
In-Reply-To: <fffd4dad-2cb9-4bc9-8a80-a70be687fd54@amd.com>


Raghavendra K T <raghavendra.kt@amd.com> writes:

> On 6/16/2025 10:52 AM, Ankur Arora wrote:
>> This series adds multi-page clearing for hugepages, improving on the
>> current page-at-a-time approach in two ways:
>>   - amortizes the per-page setup cost over a larger extent
>>   - when using string instructions, exposes the real region size to the
>>     processor. A processor could use that as a hint to optimize based
>>     on the full extent size. AMD Zen uarchs, as an example, elide
>>     allocation of cachelines for regions larger than L3-size.
>> Demand faulting a 64GB region shows good performance improvements:
>>   $ perf bench mem map -p $page-size -f demand -s 64GB -l 5
>>                   mm/folio_zero_user    x86/folio_zero_user       change
>>                    (GB/s  +- %stdev)     (GB/s  +- %stdev)
>>    pg-sz=2MB       11.82  +- 0.67%        16.48  +-  0.30%       + 39.4%
>>    pg-sz=1GB       17.51  +- 1.19%        40.03  +-  7.26% [#]   +129.9%
>> [#] Only with preempt=full|lazy because cooperatively preempted models
>> need regular invocations of cond_resched(). This limits the extent
>> sizes that can be cleared as a unit.
>> Raghavendra also tested on AMD Genoa and that shows similar
>> improvements [1].
>>
> [...]
> Sorry for coming back late on this:
> It was nice to have it integrated to perf bench mem (easy to test :)).
>
> I do see similar (almost same) improvement again with the rebased kernel
> and patchset.
> Tested only preempt=lazy and boost=1
>
> base       6.16-rc4 + 1-9 patches of this series
> patched =  6.16-rc4 + all patches
>
> SUT: Genoa+ AMD EPYC 9B24
>
>  $ perf bench mem map -p $page-size -f populate -s 64GB -l 10
>                    base               patched              change
>   pg-sz=2MB       12.731939 GB/sec    26.304263 GB/sec     106.6%
>   pg-sz=1GB       26.232423 GB/sec    61.174836 GB/sec     133.2%

Thanks for trying them out. Looks great.

--
ankur


      reply	other threads:[~2025-07-07 21:05 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16  5:22 [PATCH v4 00/13] x86/mm: Add multi-page clearing Ankur Arora
2025-06-16  5:22 ` [PATCH v4 01/13] perf bench mem: Remove repetition around time measurement Ankur Arora
2025-06-16  5:22 ` [PATCH v4 02/13] perf bench mem: Defer type munging of size to float Ankur Arora
2025-06-16  5:22 ` [PATCH v4 03/13] perf bench mem: Move mem op parameters into a structure Ankur Arora
2025-06-16  5:22 ` [PATCH v4 04/13] perf bench mem: Pull out init/fini logic Ankur Arora
2025-06-16  5:22 ` [PATCH v4 05/13] perf bench mem: Switch from zalloc() to mmap() Ankur Arora
2025-06-16  5:22 ` [PATCH v4 06/13] perf bench mem: Allow mapping of hugepages Ankur Arora
2025-06-16  5:22 ` [PATCH v4 07/13] perf bench mem: Allow chunking on a memory region Ankur Arora
2025-06-16  5:22 ` [PATCH v4 08/13] perf bench mem: Refactor mem_options Ankur Arora
2025-06-16  5:22 ` [PATCH v4 09/13] perf bench mem: Add mmap() workloads Ankur Arora
2025-06-16  5:22 ` [PATCH v4 10/13] x86/mm: Simplify clear_page_* Ankur Arora
2025-06-16 14:35   ` Dave Hansen
2025-06-16 14:38     ` Peter Zijlstra
2025-06-16 18:18     ` Ankur Arora
2025-06-16 16:48   ` kernel test robot
2025-06-16  5:22 ` [PATCH v4 11/13] x86/clear_page: Introduce clear_pages() Ankur Arora
2025-06-16  5:22 ` [PATCH v4 12/13] mm: memory: allow arch override for folio_zero_user() Ankur Arora
2025-06-16  5:22 ` [PATCH v4 13/13] x86/folio_zero_user: Add multi-page clearing Ankur Arora
2025-06-16 11:39   ` kernel test robot
2025-06-16 14:44   ` Dave Hansen
2025-06-16 14:50     ` Peter Zijlstra
2025-06-16 15:03       ` Dave Hansen
2025-06-16 18:20       ` Ankur Arora
2025-06-16 14:58     ` Matthew Wilcox
2025-06-16 18:47     ` Ankur Arora
2025-06-19 23:51       ` Ankur Arora
2025-06-16 15:06 ` [PATCH v4 00/13] x86/mm: " Dave Hansen
2025-06-16 18:25   ` Ankur Arora
2025-06-16 18:30     ` Dave Hansen
2025-06-16 18:43       ` Ankur Arora
2025-07-04  8:15 ` Raghavendra K T
2025-07-07 21:02   ` Ankur Arora [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ms9fr9xk.fsf@oracle.com \
    --to=ankur.a.arora@oracle.com \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bharata@amd.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jon.grimm@amd.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mjguzik@gmail.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=raghavendra.kt@amd.com \
    --cc=tglx@linutronix.de \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.