Re: [PATCH v3 24/68] accel/system: Add 'info accel' on human monitor

[Markus Armbruster <armbru@redhat.com>]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 2/7/25 06:58, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>> 
>>> 'info accel' dispatches to the AccelOpsClass::get_stats()
>>> and get_vcpu_stats() handlers.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> Acked-by: Richard Henderson <richard.henderson@linaro.org>
>> 
>> Standard question for new HMP commands that don't wrap around QMP
>> commands: why is the functionality not useful in QMP?
>
> So far the sole use of this command is to prove the 'split accel'
> works by using it in a test:
> https://lore.kernel.org/qemu-devel/20250620172751.94231-43-philmd@linaro.org/

Different series?  Best to add new interfaces together with their uses.

> Is it worth overloading QAPI and its documentation, and overload
> the QMP command set (even if prefixing with experimental / hidden 'x-')?
>
> If so, I don't mind implementing yet another "embedded plain HMP string
> to QMP command" in v4, or directly export each debug statistical value
> via QAPI.

Whatever the reasons for implementing something in HMP only may be, the
commit message should state them.

"Just for testing" is a valid reason for HMP-only.  It's not obvious
from the command documentation or code, though.