Re: [PATCH v2] drm/xe/oa: Expose media OA units

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 16 May 2025 13:47:51 -0700, Ashutosh Dixit wrote:
>
>  static u32 __hwe_oam_unit(struct xe_hw_engine *hwe)
>  {
> -	if (GRAPHICS_VERx100(gt_to_xe(hwe->gt)) >= 1270) {
> -		/*
> -		 * There's 1 SAMEDIA gt and 1 OAM per SAMEDIA gt. All media slices
> -		 * within the gt use the same OAM. All MTL/LNL SKUs list 1 SA MEDIA
> -		 */
> -		xe_gt_WARN_ON(hwe->gt, hwe->gt->info.type != XE_GT_TYPE_MEDIA);
> +	if (GRAPHICS_VERx100(gt_to_xe(hwe->gt)) < 1270)
> +		return 0;

Will change this to 'return XE_OA_UNIT_INVALID;' in the next revision.

>  static int xe_oa_init_oa_units(struct xe_oa *oa)
>  {
>	struct xe_gt *gt;
>	int i, ret;
>
> +	/* Needed for OAM implemenation here */

Will also fix the implementation spelling flagged by checkpatch in the next
revision.

Thanks.
--
Ashutosh