All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: pcm: Make snd_pcm_lib_malloc_pages() debug message say "allocate"
Date: Tue, 22 Apr 2025 15:00:39 +0200	[thread overview]
Message-ID: <87msc8s64o.wl-tiwai@suse.de> (raw)
In-Reply-To: <20250421085244.377228-1-wenst@chromium.org>

On Mon, 21 Apr 2025 10:52:42 +0200,
Chen-Yu Tsai wrote:
> 
> snd_pcm_lib_malloc_pages() is commonly used for allocating buffers during
> the hw_params callback, whereas preallocating buffers goes through
> preallocate_pcm_pages().
> 
> Having the same terminology in the failure debug messages in both
> misleads developers.
> 
> Change the debug message in snd_pcm_lib_malloc_pages() to use the
> term "allocate" to match its intended use.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> I found this small discrepancy in the ALSA PCM memory management debug
> messages that made it a bit confusing for me to trace code.

Thanks, applied now to for-next branch.


Takashi

      reply	other threads:[~2025-04-22 13:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21  8:52 [PATCH] ALSA: pcm: Make snd_pcm_lib_malloc_pages() debug message say "allocate" Chen-Yu Tsai
2025-04-22 13:00 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msc8s64o.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.