From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14E08C3601E for ; Thu, 10 Apr 2025 11:57:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F53910E0D3; Thu, 10 Apr 2025 11:56:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="duSWxbak"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D3C210E0D3 for ; Thu, 10 Apr 2025 11:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744286218; x=1775822218; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=CKmXBG/PEPzPtlg0BOUFBWyPS0pYatTRE4/PLiHDvaY=; b=duSWxbakaDCPhy7Euesu6Bp9N1WQCxmyNT75fRfsBiW31dRXU6RypSFY P+XJtGmdNLfWm9lPNdpjt8G+Zp99LhMcBp4yf4qkLNIR0Dt/uFB6zV/Zm eYJfEm+rGHOdEYvM7JAFb3WT6p7ncFLyzlPAZzoyK1/fkv5YY6ucCMff4 PF2Lmv/TkvB9CltZIeEqv7queBYU/9xbHOD8C0h8hOzxbpUXMpQK+58oq tmGUanZqHl3AZdUMoVEw46Gg87b+Llk+PGOxqSQdQ5Au75ndM+GQR/3MT 4LykKXO8q8XwUm2rGQl+5k0fAYDS0zJZe4f+LFhr/eVxySLkDnr3P2K1R w==; X-CSE-ConnectionGUID: kzTX1sdMT0uaXnfPL6/9ug== X-CSE-MsgGUID: pjpgmagzRbKm0vMV135aFA== X-IronPort-AV: E=McAfee;i="6700,10204,11400"; a="56779819" X-IronPort-AV: E=Sophos;i="6.15,202,1739865600"; d="scan'208";a="56779819" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 04:56:57 -0700 X-CSE-ConnectionGUID: sVWlgKpJSbOVORIwhWAQ8g== X-CSE-MsgGUID: QxMeLRLzQAK46/UYuAbt1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,202,1739865600"; d="scan'208";a="129427726" Received: from unknown (HELO localhost) ([10.237.66.160]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2025 04:56:52 -0700 From: Jani Nikula To: Matt Coster , Arnd Bergmann Cc: Frank Binns , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Krzysztof Kozlowski , Andy Shevchenko , Arnd Bergmann , Andrzej Hajda , Alex Deucher , Alessio Belle , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 01/10] drm/imagination: avoid unused-const-variable warning In-Reply-To: <7ae4be5c-b115-405e-aa57-caeaa206775b@imgtec.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20250409122131.2766719-1-arnd@kernel.org> <20250409122314.2848028-1-arnd@kernel.org> <7ae4be5c-b115-405e-aa57-caeaa206775b@imgtec.com> Date: Thu, 10 Apr 2025 14:56:48 +0300 Message-ID: <87mscout4v.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 10 Apr 2025, Matt Coster wrote: > Having said that, surely it makes sense to keep at least > *_debugfs_init() gated behind CONFIG_DEBUG_FS? If they're basically just calls to debugfs_create_{dir,file}, the compiler pretty much turns them into nops, and you'll get better build coverage. BR, Jani. -- Jani Nikula, Intel