All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>, rtm@csail.mit.edu
Cc: linux-wireless@vger.kernel.org
Subject: Re: divide by zero in ath9k_htc_choose_bslot()
Date: Wed, 02 Apr 2025 11:09:25 +0200	[thread overview]
Message-ID: <87msczlyka.fsf@toke.dk> (raw)
In-Reply-To: <addca47d-041d-4d2b-acd1-ba457f4a1b1c@oss.qualcomm.com>

Jeff Johnson <jeff.johnson@oss.qualcomm.com> writes:

> On 3/31/2025 7:17 AM, rtm@csail.mit.edu wrote:
>> Toke,
>> 
>> Yes, your fix makes the problem go away for me, and does seem
>> like the better approach.
>> 
>> Robert
>> 
>>> diff --git i/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c w/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
>>> index 547634f82183..81fa7cbad892 100644
>>> --- i/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
>>> +++ w/drivers/net/wireless/ath/ath9k/htc_drv_beacon.c
>>> @@ -290,6 +290,9 @@ void ath9k_htc_swba(struct ath9k_htc_priv *priv,
>>>         struct ath_common *common = ath9k_hw_common(priv->ah);
>>>         int slot;
>>>  
>>> +       if (!priv->cur_beacon_conf.enable_beacon)
>>> +               return;
>>> +
>>>         if (swba->beacon_pending != 0) {
>>>                 priv->beacon.bmisscnt++;
>>>                 if (priv->beacon.bmisscnt > BSTUCK_THRESHOLD) {
>> 
>
> Toke, care to submit a patch I can apply?

Yup, will do.

-Toke

      reply	other threads:[~2025-04-02  9:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-27 18:16 divide by zero in ath9k_htc_choose_bslot() rtm
2025-03-31 12:26 ` Toke Høiland-Jørgensen
2025-03-31 14:17   ` rtm
2025-04-01 18:13     ` Jeff Johnson
2025-04-02  9:09       ` Toke Høiland-Jørgensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msczlyka.fsf@toke.dk \
    --to=toke@toke.dk \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rtm@csail.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.