Re: [RFC PATCH-for-10.0] hw/vmapple: Allow running QTest framework on macOS

[Fabiano Rosas <farosas@suse.de>]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> First, the VMapple machine only works with the ARM 'host' CPU
> type, which isn't accepted for QTest:
>
>   $ qemu-system-aarch64 -M vmapple -accel qtest
>   qemu-system-aarch64: The 'host' CPU type can only be used with KVM or HVF
>
> Second, the QTest framework expects machines to be createable
> without specifying optional arguments, however the VMapple
> machine requires few of them:
>
>   $ qemu-system-aarch64 -M vmapple -accel qtest
>   qemu-system-aarch64: No firmware specified
>
>   $ qemu-system-aarch64 -M vmapple -accel qtest -bios /dev/null
>   qemu-system-aarch64: No AUX device. Please specify one as pflash drive.
>
> Restrict some code path to QTest so we can at least run check-qtest,
> otherwise we get:

Or add vmapple as an exception in qtest_cb_for_every_machine():

    for (i = 0; machines[i].name != NULL; i++) {
        /* Ignore machines that cannot be used for qtests */
        if (!strncmp("xenfv", machines[i].name, 5) ||
            g_str_equal("xenpv", machines[i].name) ||
            g_str_equal("xenpvh", machines[i].name) ||
            g_str_equal("nitro-enclave", machines[i].name)) {
            continue;
        }
        ...
    }

Anyway:

Acked-by: Fabiano Rosas <farosas@suse.de>