Re: [PATCH] x86/entry: Add __init to ia32_emulation_override_cmdline()

[Vitaly Kuznetsov <vkuznets@redhat.com>]

Nikolay Borisov <nik.borisov@suse.com> writes:

> On 10.12.24 г. 17:16 ч., Vitaly Kuznetsov wrote:
>> ia32_emulation_override_cmdline() is an early_param() arg and these
>> are only needed at boot time. In fact, all other early_param() functions
>> in arch/x86 seem to have '__init' annotation and
>> ia32_emulation_override_cmdline() is the only exception.
>> 
>> Fixes: a11e097504ac ("x86: Make IA32_EMULATION boot time configurable")
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>
>

Thanks!

> nit: Does it really warrant a Fix tag, it's not a bug per-se, just frees 
> up some memory?

I don't think we have any issues with early_param() functions without
__init currently, by 'Fixes:' I meant "this fixes commit ... which was
sub-optimal" and to help backporters. I'm absolutely fine with dropping
it if that's the consensus.

-- 
Vitaly