From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C79ED49205 for ; Mon, 18 Nov 2024 10:11:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D655A10E486; Mon, 18 Nov 2024 10:11:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="h8W2Oucq"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1478310E1A4; Mon, 18 Nov 2024 10:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731924673; x=1763460673; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=LPVEc3SBnqPhNLow8kd01cndoiNDR2c0uBbFgG5wFCA=; b=h8W2Oucqd+wkzpck8iFm4v0ubQ4gXxAkeGT7DIpah2FlR7iVQqzF5aSd 9Gu2u+MNRsvKliFp93m2tNn4ZyBVhDEJAnuddOYs3FzGylMtbruq/MjS4 +zpa4vjKdOVs1ubWpPeM0E7gdfMdA5Gg+Jw7f2KNaX7bu+VZV6LOSu0Xc x3maOGQu36nxYU/DBj0fZko7rPnGcVV0IzxQaLEH/cs4bPdfjb+F9DuxO QKHKEI/7F+B9b7KUojpmTSl5PpesRE1fNInhlfYBkaX6r+PFwVycCGBaV 5Of0Bxg9FKnfHo2al0+e6vdu1l14G1nfItYSMXC7DiZGNp9ipJQqYVYNO Q==; X-CSE-ConnectionGUID: rrl7pqivQyWyzcmSn9pS1Q== X-CSE-MsgGUID: Phd5xinbShW57ImJbWAvoQ== X-IronPort-AV: E=McAfee;i="6700,10204,11259"; a="31278896" X-IronPort-AV: E=Sophos;i="6.12,163,1728975600"; d="scan'208";a="31278896" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2024 02:11:12 -0800 X-CSE-ConnectionGUID: Ye9B2MTzSreXL8hy2uW3Yw== X-CSE-MsgGUID: 1IaCFaIKSn+u08XITnRaAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,163,1728975600"; d="scan'208";a="112478172" Received: from jkrzyszt-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.246.148]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2024 02:10:48 -0800 From: Jani Nikula To: Dmitry Baryshkov , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Karol Herbst , Lyude Paul , Danilo Krummrich , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , Xinhui Pan , Alain Volmat , Raphael Gallais-Pou , Liviu Dudau , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Peter Senna Tschudin , Ian Ray , Martyn Welch , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Stefan Agner , Alison Wang , Patrik Jakobsson , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Dave Airlie , Gerd Hoffmann , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Chen-Yu Tsai , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Dave Stevenson , =?utf-8?Q?Ma=C3=ADra?= Canal , Raspberry Pi Kernel Maintenance , Gurchetan Singh , Chia-I Wu , Zack Rusin , Broadcom internal kernel review list Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH 4/5] drm/connector: make mode_valid_ctx accept const struct drm_display_mode In-Reply-To: <20241115-drm-connector-mode-valid-const-v1-4-b1b523156f71@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20241115-drm-connector-mode-valid-const-v1-0-b1b523156f71@linaro.org> <20241115-drm-connector-mode-valid-const-v1-4-b1b523156f71@linaro.org> Date: Mon, 18 Nov 2024 12:10:44 +0200 Message-ID: <87mshw4ztn.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, 15 Nov 2024, Dmitry Baryshkov wrote: > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > accept const struct drm_display_mode argument. Change the mode_valid_ctx > callback of drm_connector to also accept const argument. > > Signed-off-by: Dmitry Baryshkov Acked-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- > include/drm/drm_modeset_helper_vtables.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > index 7be8fb047b6c17cb37b9021a2dbf430f0aaecfa2..cfefd89209ca864e19771c538ca00016f9322e74 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -1432,7 +1432,7 @@ static int intel_dp_mst_get_modes(struct drm_connector *connector) > > static int > intel_dp_mst_mode_valid_ctx(struct drm_connector *connector, > - struct drm_display_mode *mode, > + const struct drm_display_mode *mode, > struct drm_modeset_acquire_ctx *ctx, > enum drm_mode_status *status) > { > diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h > index ec59015aec3cf3ba01510031c55df8c0b3e0b382..fa9ee6a128bec0205f501df6f7634757f5fcb9ee 100644 > --- a/include/drm/drm_modeset_helper_vtables.h > +++ b/include/drm/drm_modeset_helper_vtables.h > @@ -1006,7 +1006,7 @@ struct drm_connector_helper_funcs { > * > */ > int (*mode_valid_ctx)(struct drm_connector *connector, > - struct drm_display_mode *mode, > + const struct drm_display_mode *mode, > struct drm_modeset_acquire_ctx *ctx, > enum drm_mode_status *status); -- Jani Nikula, Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40A66CCD1AA for ; Mon, 20 Oct 2025 11:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3gAdqWw0KAajqX4rnOIS/PSgoWPW09mTcmu7qL6f/kM=; b=GYE7ViXZx41FBm 6Igada4x6TP1g5EWVXbcRhO/6O81ut/tLQukEQL/NB0j/qXp5jlsXcKhm1WtSk5p/GoU+Fhs/u1U5 50X0JZbUzEPbYZSbTTLgQCgyjqkYGBKvY1YfeskUSq41jDXcdf3AInpCCGacC7j6sLoCKp2XZvKQM 7WvgQ2c6j0a1HquvEcbNr+RxV0LRljVnKiqSyI11tjyD4BxxoxVstEBkM3q4wgsp/GG7pEmopX5JV OtzyBFZChr/pq248nJGst2Xp9dB/P/4KpFxygLLNKg9RV7n8tOvct12w2z51ZEcQO6kT4ptSBXyt2 rSZJiiLeWLsOmEoIsv5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAoVn-0000000D9B3-1Wjw; Mon, 20 Oct 2025 11:57:15 +0000 Received: from mgamail.intel.com ([192.198.163.19]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tCyiv-000000091f9-2azH; Mon, 18 Nov 2024 10:11:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731924674; x=1763460674; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=LPVEc3SBnqPhNLow8kd01cndoiNDR2c0uBbFgG5wFCA=; b=FzNF8p8DQtGR3gufc1YDVEY34v3t52gp1THnnHxw/F+a7HmhjQMsqJya OH934tNvL9+IA6gC7XWRQyO2I6T17J0xHqgNbg8z7dc6aDY/WyLEA6v/E O8nt9RtxX2jD8kW41x95m+3jUOnul6C7mylHv7ZwS5gP5rf+wEslZwVC5 cNcSJtMDOkvy8OfBdIfiQop4yLNThN3buggMvUSmGC5xDFtGBQq72iRYl 9XhemByCOPhy/heONrjtCY7glzX3C+uNh1/iUBO0pzePZEL4f4k/DBdcU MwrKZoPmgj6ThaTh6O5x3NiiDR4d2apKM/Hl/2e/S/Lh1aaE3k6fnf5eO g==; X-CSE-ConnectionGUID: kE9rGEj+S6eBqv1ag2K/jw== X-CSE-MsgGUID: /CvmjvhdSqmY242aM4IbKw== X-IronPort-AV: E=McAfee;i="6700,10204,11259"; a="31278897" X-IronPort-AV: E=Sophos;i="6.12,163,1728975600"; d="scan'208";a="31278897" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2024 02:11:12 -0800 X-CSE-ConnectionGUID: Ye9B2MTzSreXL8hy2uW3Yw== X-CSE-MsgGUID: 1IaCFaIKSn+u08XITnRaAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,163,1728975600"; d="scan'208";a="112478172" Received: from jkrzyszt-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.246.148]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2024 02:10:48 -0800 From: Jani Nikula To: Dmitry Baryshkov , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Karol Herbst , Lyude Paul , Danilo Krummrich , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , Xinhui Pan , Alain Volmat , Raphael Gallais-Pou , Liviu Dudau , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Peter Senna Tschudin , Ian Ray , Martyn Welch , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Stefan Agner , Alison Wang , Patrik Jakobsson , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , Dave Airlie , Gerd Hoffmann , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Chen-Yu Tsai , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Dave Stevenson , =?utf-8?Q?Ma=C3=ADra?= Canal , Raspberry Pi Kernel Maintenance , Gurchetan Singh , Chia-I Wu , Zack Rusin , Broadcom internal kernel review list Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH 4/5] drm/connector: make mode_valid_ctx accept const struct drm_display_mode In-Reply-To: <20241115-drm-connector-mode-valid-const-v1-4-b1b523156f71@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20241115-drm-connector-mode-valid-const-v1-0-b1b523156f71@linaro.org> <20241115-drm-connector-mode-valid-const-v1-4-b1b523156f71@linaro.org> Date: Mon, 18 Nov 2024 12:10:44 +0200 Message-ID: <87mshw4ztn.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241118_021113_673282_ABBB36CC X-CRM114-Status: GOOD ( 15.39 ) X-Mailman-Approved-At: Mon, 20 Oct 2025 04:56:19 -0700 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, 15 Nov 2024, Dmitry Baryshkov wrote: > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > accept const struct drm_display_mode argument. Change the mode_valid_ctx > callback of drm_connector to also accept const argument. > > Signed-off-by: Dmitry Baryshkov Acked-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- > include/drm/drm_modeset_helper_vtables.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > index 7be8fb047b6c17cb37b9021a2dbf430f0aaecfa2..cfefd89209ca864e19771c538ca00016f9322e74 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -1432,7 +1432,7 @@ static int intel_dp_mst_get_modes(struct drm_connector *connector) > > static int > intel_dp_mst_mode_valid_ctx(struct drm_connector *connector, > - struct drm_display_mode *mode, > + const struct drm_display_mode *mode, > struct drm_modeset_acquire_ctx *ctx, > enum drm_mode_status *status) > { > diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h > index ec59015aec3cf3ba01510031c55df8c0b3e0b382..fa9ee6a128bec0205f501df6f7634757f5fcb9ee 100644 > --- a/include/drm/drm_modeset_helper_vtables.h > +++ b/include/drm/drm_modeset_helper_vtables.h > @@ -1006,7 +1006,7 @@ struct drm_connector_helper_funcs { > * > */ > int (*mode_valid_ctx)(struct drm_connector *connector, > - struct drm_display_mode *mode, > + const struct drm_display_mode *mode, > struct drm_modeset_acquire_ctx *ctx, > enum drm_mode_status *status); -- Jani Nikula, Intel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip