All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Murad Masimov <m.masimov@maxima.ru>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Vitaly Rodionov <vitalyr@opensource.cirrus.com>,
	<linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lvc-project@linuxtesting.org>
Subject: Re: [PATCH] ALSA: hda/cs8409: Fix possible NULL dereference
Date: Fri, 11 Oct 2024 11:14:18 +0200	[thread overview]
Message-ID: <87msjbm26t.wl-tiwai@suse.de> (raw)
In-Reply-To: <20241010221649.1305-1-m.masimov@maxima.ru>

On Fri, 11 Oct 2024 00:16:45 +0200,
Murad Masimov wrote:
> 
> If snd_hda_gen_add_kctl fails to allocate memory and returns NULL, then
> NULL pointer dereference will occur in the next line.
> 
> Since dolphin_fixups function is a hda_fixup function which is not supposed
> to return any errors, add simple check before dereference, ignore the fail.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 20e507724113 ("ALSA: hda/cs8409: Add support for dolphin")
> Signed-off-by: Murad Masimov <m.masimov@maxima.ru>

Thanks, applied.


Takashi

      reply	other threads:[~2024-10-11  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10 22:16 [PATCH] ALSA: hda/cs8409: Fix possible NULL dereference Murad Masimov
2024-10-11  9:14 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msjbm26t.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=m.masimov@maxima.ru \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=vitalyr@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.