From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Pottumuttu, Sai Teja" <sai.teja.pottumuttu@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>,
intel-gfx@lists.freedesktop.org, ville.syrjala@intel.com,
sai.teja.pottumuttu@intel.com
Subject: Re: [PATCH] drm/i915/icl: Update csc and gamma enable checks
Date: Thu, 03 Oct 2024 19:02:24 +0300 [thread overview]
Message-ID: <87msjlrx7z.fsf@intel.com> (raw)
In-Reply-To: <55bb7824-15fd-43fa-a285-03533d693a66@intel.com>
On Thu, 03 Oct 2024, "Pottumuttu, Sai Teja" <sai.teja.pottumuttu@intel.com> wrote:
> On 03-10-2024 21:16, Ville Syrjälä wrote:
>> No. The current code already works correctly, and pipe_csc_enable and
>> gamma_enable are not meant to be used on icl+.
>
> So, if that is the case, would it be good to still have the
> icl_get_config function here and completely remove the gamma_enable and
> csc_enable setting part so that its clear that we don't need these in icl+?
Then you'll lose the check on those bit actually having been left at 0.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-10-03 16:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 9:03 [PATCH] drm/i915/icl: Update csc and gamma enable checks Sai Teja Pottumuttu
2024-10-03 9:58 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-10-03 10:46 ` [PATCH] " Jani Nikula
2024-10-03 11:10 ` Ville Syrjälä
2024-10-03 14:22 ` Matt Roper
2024-10-03 14:32 ` Ville Syrjälä
2024-10-03 14:58 ` Ville Syrjälä
2024-10-03 15:38 ` Pottumuttu, Sai Teja
2024-10-03 15:46 ` Ville Syrjälä
2024-10-03 15:56 ` Pottumuttu, Sai Teja
2024-10-03 16:02 ` Jani Nikula [this message]
2024-10-03 16:05 ` Matt Roper
2024-10-03 16:12 ` Ville Syrjälä
2024-10-03 16:20 ` Matt Roper
2024-10-03 16:43 ` Ville Syrjälä
2024-10-07 19:33 ` ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msjlrx7z.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=sai.teja.pottumuttu@intel.com \
--cc=ville.syrjala@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.