From: Philip Kaludercic <philipk@posteo.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Best practices for indicating what address to send patches to?
Date: Fri, 19 Jul 2024 17:48:51 +0000 [thread overview]
Message-ID: <87msmdmfwc.fsf@posteo.net> (raw)
In-Reply-To: <xmqqh6cmzspe.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 18 Jul 2024 07:21:33 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Hi, I was wondering if anyone had a good suggestion on how to indicate
>> where to send a patch to. Ideally I'd like to have "sendemail.to"
>> configured on cloning, but that isn't possible IIUC. There also doesn't
>> seem to be a conventional file like ".git-email" that would list where
>> to send a patch, without having to look it up.
>>
>> Is this intentional, has it been discussed in the past or is there the
>> chance that it might be improved upon in the future?
>
> The usual convention is to have the patch submission address (if a
> project uses e-mail based patch as its workflow) together with other
> rules and guidelines the contributors are expected to adhere to in
> documents like README, CONTRIBUTING, etc. As an e-mailed patch that
> does not follow established conventions is not necessarily useful to
> the receiving projects, it is a good practice to put these pieces of
> information crucial to start contributing in a single place.
>
> It would not be an improvement to add a mechanism to make it easier
> to find "here is the address" to a reader who hasn't even discovered
> where these contributor guide documents are.
But is that an argument to prevent projects with mild or now contributor
guidelines to make the patch-driven workflow more difficult? I've often
contributed to a project by quickly checking out the source code,
changing something and then sending a patch (this is easier in the
context of Emacs, because we have the a `vc-default-patch-addressee'
variable). My suggestion is by no means to mandate this kind of an
option, but there are situations where this kind of configurability
would be useful, e.g. for Sourcehut projects.
> Thanks.
--
Philip Kaludercic on peregrine
next prev parent reply other threads:[~2024-07-19 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 10:49 Best practices for indicating what address to send patches to? Philip Kaludercic
2024-07-18 14:21 ` Junio C Hamano
2024-07-19 17:48 ` Philip Kaludercic [this message]
2024-07-19 18:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msmdmfwc.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.