From: Thomas Gleixner <tglx@linutronix.de>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>,
Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [PATCH V2] irqchip/loongson-eiointc: Use early_cpu_to_node() instead of cpu_to_node()
Date: Fri, 21 Jun 2024 22:42:46 +0200 [thread overview]
Message-ID: <87msnem3i1.ffs@tglx> (raw)
In-Reply-To: <20240620020625.3851354-1-chenhuacai@loongson.cn>
On Thu, Jun 20 2024 at 10:06, Huacai Chen wrote:
> When we use "nr_cpus=n" to hard limit the CPU number, cpu_to_node() is
> not usable because it can only applied on "possible" CPUs. On the other
> hand, early_cpu_to_node() can be always used instead.
We use nothing...
Aside of that you fail to explain what the problem is (i.e. the
malfunction) and why using early_cpu_to_node() is fixing it.
> #define pr_fmt(fmt) "eiointc: " fmt
>
> +#include <asm/numa.h>
asm includes come after the linux includes.
> #include <linux/cpuhotplug.h>
Thanks,
tglx
next prev parent reply other threads:[~2024-06-21 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 2:06 [PATCH V2] irqchip/loongson-eiointc: Use early_cpu_to_node() instead of cpu_to_node() Huacai Chen
2024-06-21 20:42 ` Thomas Gleixner [this message]
2024-06-22 2:49 ` Huacai Chen
2024-06-22 10:17 ` Thomas Gleixner
2024-06-22 11:23 ` Huacai Chen
2024-06-22 21:21 ` Thomas Gleixner
2024-06-23 2:55 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msnem3i1.ffs@tglx \
--to=tglx@linutronix.de \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=loongarch@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.