Re: [Buildroot] [PATCH 1/1] configs/at91sam9x5ek_dev_defconfig: fix Linux compilation error

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Dario" == Dario Binacchi <dario.binacchi@amarulasolutions.com> writes:

 > This patch adapts the Linux commit 790756c7e0229 ("ARM: 8933/1: replace
 > Sun/Solaris style flag on section directive") to fix compilation errors.

 > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
 > ---
 >  ...ce-Sun-Solaris-style-flag-on-section.patch | 71 +++++++++++++++++++
 >  configs/at91sam9x5ek_dev_defconfig            |  1 +
 >  2 files changed, 72 insertions(+)
 >  create mode 100644 board/atmel/at91sam9x5ek_dev/patches/linux/0001-ARM-8933-1-replace-Sun-Solaris-style-flag-on-section.patch

 > diff --git a/board/atmel/at91sam9x5ek_dev/patches/linux/0001-ARM-8933-1-replace-Sun-Solaris-style-flag-on-section.patch b/board/atmel/at91sam9x5ek_dev/patches/linux/0001-ARM-8933-1-replace-Sun-Solaris-style-flag-on-section.patch
 > new file mode 100644
 > index 000000000000..8bc5919b0411
 > --- /dev/null
 > +++ b/board/atmel/at91sam9x5ek_dev/patches/linux/0001-ARM-8933-1-replace-Sun-Solaris-style-flag-on-section.patch
 > @@ -0,0 +1,71 @@
 > +From 25d046fbe70400c709cb00855d7f18c6000d1325 Mon Sep 17 00:00:00 2001
 > +From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
 > +Date: Fri, 24 May 2024 19:10:07 +0200
 > +Subject: [PATCH] ARM: 8933/1: replace Sun/Solaris style flag on section
 > + directive
 > +
 > +The patch is an adaptation of Linux commit 790756c7e0229 ("ARM: 8933/1:
 > +replace Sun/Solaris style flag on section directive").
 > +
 > +Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
 > +Upstream: N/A [Buildroot specific]

How about instead directly taking the backport of this to the 4.19.y
stable tree, E.G.:

commit 762d2dcd9e233e3025f8627ea65f23e568045edb
Author: Nick Desaulniers <ndesaulniers@google.com>
Date:   Mon Nov 4 19:31:45 2019 +0100

    ARM: 8933/1: replace Sun/Solaris style flag on section directive

    [ Upstream commit 790756c7e0229dedc83bf058ac69633045b1000e ]

    It looks like a section directive was using "Solaris style" to declare
    the section flags. Replace this with the GNU style so that Clang's
    integrated assembler can assemble this directive.

    The modified instances were identified via:
    $ ag \.section | grep #

    Link: https://ftp.gnu.org/old-gnu/Manuals/gas-2.9.1/html_chapter/as_7.html#SEC119
    Link: https://github.com/ClangBuiltLinux/linux/issues/744
    Link: https://bugs.llvm.org/show_bug.cgi?id=43759
    Link: https://reviews.llvm.org/D69296

    Acked-by: Nicolas Pitre <nico@fluxnic.net>
    Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
    Reviewed-by: Stefan Agner <stefan@agner.ch>
    Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
    Suggested-by: Fangrui Song <maskray@google.com>
    Suggested-by: Jian Cai <jiancai@google.com>
    Suggested-by: Peter Smith <peter.smith@linaro.org>
    Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>

Doesn't that directly apply without any further adoptions?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot