From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id s14-20020adfdb0e000000b0033afce63fd0sm758630wri.53.2024.01.30.02.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 02:02:21 -0800 (PST) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id ACB675F9D3; Tue, 30 Jan 2024 10:02:20 +0000 (GMT) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Manos Pitsidianakis Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-block@nongnu.org, peter.maydell@linaro.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v3 2/6] hw/arm/z2: convert DPRINTF to trace events and guest errors In-Reply-To: <799c5141c5751cf2341e1d095349612e046424a8.1706544115.git.manos.pitsidianakis@linaro.org> (Manos Pitsidianakis's message of "Mon, 29 Jan 2024 18:09:37 +0200") References: <799c5141c5751cf2341e1d095349612e046424a8.1706544115.git.manos.pitsidianakis@linaro.org> User-Agent: mu4e 1.11.27; emacs 29.1 Date: Tue, 30 Jan 2024 10:02:20 +0000 Message-ID: <87mssnqgur.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TUID: 1vwm1PbNK5eN Manos Pitsidianakis writes: > Tracing DPRINTFs to stderr might not be desired. A developer that relies > on trace events should be able to opt-in to each trace event and rely on > QEMU's log redirection, instead of stderr by default. > > This commit converts DPRINTFs in this file that are used for tracing > into trace events. DPRINTFs that report guest errors are logged with > LOG_GUEST_ERROR. > > Signed-off-by: Manos Pitsidianakis Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro