From: Mattijs Korpershoek <mkorpershoek@baylibre.com>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Tom Rini <trini@konsulko.com>,
Igor Opaniuk <igor.opaniuk@gmail.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry
Date: Thu, 21 Dec 2023 17:07:34 +0100 [thread overview]
Message-ID: <87msu31qux.fsf@baylibre.com> (raw)
In-Reply-To: <CAPLW+4nH3XO1kZrpsc3Q-g=8eX0fuDqTy1f-etynyXntTAFnEw@mail.gmail.com>
Hi Sam,
Thank you for your review.
On Thu, Dec 21, 2023 at 08:15, Sam Protsenko <semen.protsenko@linaro.org> wrote:
> Hi Mattijs,
>
> On Wed, Dec 20, 2023 at 10:43 AM Mattijs Korpershoek
> <mkorpershoek@baylibre.com> wrote:
>>
>> Commit 19a91f2464a8 ("Create a new boot/ directory") moved the
>> android_ab.c code under boot/android_ab but did not update
>> the MAINTAINERS entry.
>
> Thanks for the patch! Would you mind adding corresponding "Fixes" tag
> below your Signed-off?
I don't mind, will send a v2.
>
> Other than that LGTM:
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
>
>>
>> Update it so that the maintainer will get cc'ed again.
>>
>> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>> ---
>> MAINTAINERS | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 7c1cb2dc4dc0..f6de883a7d8f 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -60,8 +60,8 @@ ANDROID AB
>> M: Igor Opaniuk <igor.opaniuk@gmail.com>
>> R: Sam Protsenko <semen.protsenko@linaro.org>
>> S: Maintained
>> +F: boot/android_ab.c
>> F: cmd/ab_select.c
>> -F: common/android_ab.c
>> F: doc/android/ab.rst
>> F: include/android_ab.h
>> F: test/py/tests/test_android/test_ab.py
>>
>> ---
>> base-commit: 9e53e45292ee2f1d9d2ccc59914b161bef9b10d7
>> change-id: 20231220-maintainers-fix-ab-2afa7cee97bd
>>
>> Best regards,
>> --
>> Mattijs Korpershoek <mkorpershoek@baylibre.com>
>>
prev parent reply other threads:[~2023-12-21 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 16:42 [PATCH] MAINTAINERS: Fix ANDROID AB unknown file entry Mattijs Korpershoek
2023-12-21 14:15 ` Sam Protsenko
2023-12-21 16:07 ` Mattijs Korpershoek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msu31qux.fsf@baylibre.com \
--to=mkorpershoek@baylibre.com \
--cc=igor.opaniuk@gmail.com \
--cc=semen.protsenko@linaro.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.