From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88FDCC4332F for ; Mon, 6 Nov 2023 12:45:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B7D810E2F1; Mon, 6 Nov 2023 12:45:19 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8674610E2F1 for ; Mon, 6 Nov 2023 12:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699274716; x=1730810716; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Qd9TgyWfF3orOTs+n99nqulXQRMVqKTpQeDGEu6AAqE=; b=ILSr0/Awq7+t4r1hQwD4/K4oLDkpn2F+fzGrfAucFk8XQvB4WryPrXr1 el6AKY5rHYb9DxkK/YrYuKVABjuQVPH8xjfVY+G5qmKYvpC+k9w/anvN1 hLeWV2jDzGYtUtnMs2vYZpr6D0kJs2isNW+1+wrk0ovwicBe4cU1spvzh ZghduoQ7GwYaPLGdsa0N68qbPzxGL6VoQ4vvrtWXSZ/rlJNxp925v1dlR vnpHwE0A4lb7zuywbGaRO8nRMe0nBidbTR1jaBoOxDj2ME64JIOJCDskB bpPoKqK/Pl+zMswnNGq6ju+AFUbyFH8/zHBfqqL2XScxiy2EsVWB0tDtj g==; X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="369471871" X-IronPort-AV: E=Sophos;i="6.03,281,1694761200"; d="scan'208";a="369471871" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 04:45:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10885"; a="879433047" X-IronPort-AV: E=Sophos;i="6.03,281,1694761200"; d="scan'208";a="879433047" Received: from lpilolli-mobl.ger.corp.intel.com (HELO localhost) ([10.252.36.222]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 04:45:13 -0800 From: Jani Nikula To: Nirmoy Das , intel-gfx@lists.freedesktop.org In-Reply-To: <20231025102826.16955-1-nirmoy.das@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20231025102826.16955-1-nirmoy.das@intel.com> Date: Mon, 06 Nov 2023 14:45:11 +0200 Message-ID: <87msvryrs8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Intel-gfx] [PATCH] drm/i915/mtl: Apply notify_guc to all GTs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrzej Hajda , Rodrigo Vivi , Nirmoy Das Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 25 Oct 2023, Nirmoy Das wrote: > Handle platforms with multiple GTs by iterate over all GTs. > Add a Fixes commit so this gets propagated for MTL support. > > Fixes: 213c43676beb ("drm/i915/mtl: Remove the 'force_probe' requirement for Meteor Lake") This came up in another patch. I don't like abusing Fixes: like this. I understand the motivation here, but this patch does not fix the referenced commit. BR, Jani. > Suggested-by: John Harrison > Cc: Jani Nikula > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: Andi Shyti > Cc: Andrzej Hajda > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i915/i915_debugfs_params.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_debugfs_params.c b/drivers/gpu/drm/i915/i915_debugfs_params.c > index 614bde321589..8bca02025e09 100644 > --- a/drivers/gpu/drm/i915/i915_debugfs_params.c > +++ b/drivers/gpu/drm/i915/i915_debugfs_params.c > @@ -38,10 +38,13 @@ static int i915_param_int_open(struct inode *inode, struct file *file) > > static int notify_guc(struct drm_i915_private *i915) > { > - int ret = 0; > + struct intel_gt *gt; > + int i, ret = 0; > > - if (intel_uc_uses_guc_submission(&to_gt(i915)->uc)) > - ret = intel_guc_global_policies_update(&to_gt(i915)->uc.guc); > + for_each_gt(gt, i915, i) { > + if (intel_uc_uses_guc_submission(>->uc)) > + ret = intel_guc_global_policies_update(>->uc.guc); > + } > > return ret; > } -- Jani Nikula, Intel