From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Shung-Hsi Yu <shung-hsi.yu@suse.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, Mohamed Mahmoud <mmahmoud@redhat.com>
Subject: Re: Hitting verifier backtracking bug on 6.5.5 kernel
Date: Fri, 20 Oct 2023 18:30:48 +0200 [thread overview]
Message-ID: <87mswds1c7.fsf@toke.dk> (raw)
In-Reply-To: <87fs29uppj.fsf@toke.dk>
Toke Høiland-Jørgensen <toke@redhat.com> writes:
> Shung-Hsi Yu <shung-hsi.yu@suse.com> writes:
>
>> Patch based on Andrii's analysis.
>>
>> Given that both BPF_END and BPF_NEG always operates on dst_reg itself
>> and that bt_is_reg_set(bt, dreg) was already checked I believe we can
>> just return with no futher action.
>
> Alright, manually applied this to bpf-next and indeed this enables the
> netobserv-bpf-agent to load successfully. Care to submit a formal patch?
> In that case please add my:
>
> Tested-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> Thanks!
Friendly ping - are you planning to submit an official patch for this? :)
-Toke
next prev parent reply other threads:[~2023-10-20 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 20:25 Hitting verifier backtracking bug on 6.5.5 kernel Toke Høiland-Jørgensen
2023-10-13 21:11 ` Andrii Nakryiko
2023-10-16 19:36 ` Toke Høiland-Jørgensen
2023-10-16 20:22 ` Andrii Nakryiko
2023-10-17 11:08 ` Toke Høiland-Jørgensen
2023-10-17 12:16 ` Mohamed Mahmoud
2023-10-17 15:39 ` Shung-Hsi Yu
2023-10-17 15:26 ` Shung-Hsi Yu
2023-10-17 17:22 ` Alexei Starovoitov
2023-10-17 17:24 ` Toke Høiland-Jørgensen
2023-10-20 16:30 ` Toke Høiland-Jørgensen [this message]
2023-10-23 2:08 ` Shung-Hsi Yu
2023-10-23 9:27 ` Toke Høiland-Jørgensen
2023-10-30 14:16 ` Shung-Hsi Yu
2023-10-30 14:44 ` Toke Høiland-Jørgensen
2023-10-17 5:33 ` Hengqi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mswds1c7.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=mmahmoud@redhat.com \
--cc=shung-hsi.yu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.