From: Markus Armbruster <armbru@redhat.com>
To: Ani Sinha <anisinha@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Philippe Mathieu-Daude <philmd@linaro.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/acpi: changes towards enabling -Wshadow=local
Date: Fri, 29 Sep 2023 07:47:28 +0200 [thread overview]
Message-ID: <87msx5jztb.fsf@pond.sub.org> (raw)
In-Reply-To: <20230922124203.127110-1-anisinha@redhat.com> (Ani Sinha's message of "Fri, 22 Sep 2023 18:12:02 +0530")
Ani Sinha <anisinha@redhat.com> writes:
> Code changes in acpi that addresses all compiler complaints coming from enabling
> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing
> other local variables or parameters. These makes the code confusing and/or adds
> bugs that are difficult to catch.
>
> The code is tested to build with and without the flag turned on.
>
> CC: Markus Armbruster <armbru@redhat.com>
> CC: Philippe Mathieu-Daude <philmd@linaro.org>
> CC: mst@redhat.com
> CC: imammedo@redhat.com
> Message-Id: <87r0mqlf9x.fsf@pond.sub.org>
This is my "Help wanted for enabling -Wshadow=local" post.
A commit's Message-Id tag is supposed to point to the patch submission
e-mail, and git-am will add that:
Message-ID: <20230922124203.127110-1-anisinha@redhat.com>
We'll have two Message-IDs then. Confusing.
Could perhaps use
See-also: Message-Id: <87r0mqlf9x.fsf@pond.sub.org>
but I doubt it's worth the bother.
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
Queued less the extra Message-Id, thanks!
next prev parent reply other threads:[~2023-09-29 5:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 12:42 [PATCH] hw/acpi: changes towards enabling -Wshadow=local Ani Sinha
2023-09-22 16:03 ` Michael S. Tsirkin
2023-09-29 5:47 ` Markus Armbruster [this message]
2023-09-29 5:54 ` Ani Sinha
2023-09-29 6:13 ` Markus Armbruster
2023-09-29 6:15 ` Ani Sinha
2023-09-29 8:02 ` Markus Armbruster
2023-09-29 8:08 ` Ani Sinha
2023-09-29 8:46 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msx5jztb.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=anisinha@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.