From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: buildroot@buildroot.org, Daniel Price <daniel.price@gmail.com>,
Jens Maus <mail@jens-maus.de>, Martin Bark <martin@barkynet.com>
Subject: Re: [Buildroot] [PATCH v2] package/nodejs: fix parallel build
Date: Tue, 26 Sep 2023 10:53:16 +0200 [thread overview]
Message-ID: <87msx9uxhf.fsf@48ers.dk> (raw)
In-Reply-To: <20230924095619.GG1469982@scaer> (Yann E. MORIN's message of "Sun, 24 Sep 2023 11:56:19 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Jens, All,
> On 2023-09-23 18:04 +0200, Jens Maus via buildroot spake thusly:
>> In ninja-based nodejs builds performing parallel builds using "make -jX"
>> is not working during buildroot initiated builds because the JOBS
>> variable is not set in the MAKE_OPTS variables in nodejs.mk. This commit
>> remedies the issue by setting JOBS to BR2_JLEVEL.
> I was very confused that nodejs would not build in parallel; that would
> have made for very, very,very long builds. And indeed, it does build in
> parallel, in fact.
> However, what it does, is use as many CPUs as are available, without
> accounting for the value set by the user in BR2_JLEVEL, thus
> overshooting the limits set by the user.
> So, I reworded the whoe commit log to explain that.
> Applied to master, thanks.
Committed to 2023.02.x, 2023.05.x and 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-26 8:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 9:39 [Buildroot] [PATCH] package/nodejs: fix parallel build Jens Maus via buildroot
2023-09-23 10:09 ` Yann E. MORIN
2023-09-23 11:07 ` Jens Maus via buildroot
2023-09-23 16:20 ` Jens Maus via buildroot
2023-09-23 10:59 ` [Buildroot] [PATCH 1/1] package/nodejs: fix cross-compile builds Jens Maus via buildroot
2023-09-24 16:36 ` Yann E. MORIN
2023-09-27 11:46 ` Peter Korsgaard
2023-09-23 16:04 ` [Buildroot] [PATCH v2] package/nodejs: fix parallel build Jens Maus via buildroot
2023-09-24 9:56 ` Yann E. MORIN
2023-09-26 8:53 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msx9uxhf.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=daniel.price@gmail.com \
--cc=mail@jens-maus.de \
--cc=martin@barkynet.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.