From: Markus Armbruster <armbru@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@aj.id.au>
Subject: Re: [PATCH 0/4] aspeed: Clean up local variable shadowing
Date: Sat, 23 Sep 2023 09:13:49 +0200 [thread overview]
Message-ID: <87msxdmkeq.fsf@pond.sub.org> (raw)
In-Reply-To: <838837dc-0d95-1d6c-3cfc-e321c9c01a7d@kaod.org> ("Cédric Le Goater"'s message of "Fri, 22 Sep 2023 21:00:37 +0200")
Cédric Le Goater <clg@kaod.org> writes:
> On 9/22/23 20:20, Philippe Mathieu-Daudé wrote:
>> On 22/9/23 17:59, Cédric Le Goater wrote:
>>> Hello,
>>>
>>> Here are cleanups for local variable shadowing warnings in aspeed models.
>>>
>>> Joel, Andrew,
>>>
>>> Could you please double check patch 4 ?
>> Could Markus' MAKE_IDENTFIER() help there?
>
> ah ! you typed too fast and I also read too fast, as :
>
> MARKUS_IDENTIFIER()
>
> and I liked it :)
LOL
> but what is MAKE_IDENTIFIER ? really, please explain.
Philippe is referring to
[PATCH v3 7/7] qobject atomics osdep: Make a few macros more hygienic
Message-ID: <20230921121312.1301864-8-armbru@redhat.com>
which tweaks MAX() to permit nesting without shadowing. Your PATCH 4
may not be needed if you base on it.
MAKE_IDENTIFIER() is a helper macro introduced in that patch.
You can fetch the patch from https://repo.or.cz/qemu/armbru.git branch
shadow-next, along with collected other shadowing patches.
Questions?
next prev parent reply other threads:[~2023-09-23 7:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 15:59 [PATCH 0/4] aspeed: Clean up local variable shadowing Cédric Le Goater
2023-09-22 15:59 ` [PATCH 1/4] aspeed/i2c: " Cédric Le Goater
2023-09-22 18:22 ` Philippe Mathieu-Daudé
2023-09-27 2:38 ` Joel Stanley
2023-09-22 15:59 ` [PATCH 2/4] aspeed: " Cédric Le Goater
2023-09-22 18:23 ` Philippe Mathieu-Daudé
2023-09-23 6:34 ` Markus Armbruster
2023-09-23 7:10 ` Cédric Le Goater
2023-09-22 15:59 ` [PATCH 3/4] aspeed/i3c: Rename variable shadowing a local Cédric Le Goater
2023-09-22 18:28 ` Philippe Mathieu-Daudé
2023-09-25 6:29 ` Andrew Jeffery
2023-09-22 15:59 ` [PATCH 4/4] aspeed/timer: Clean up local variable shadowing Cédric Le Goater
2023-09-22 18:32 ` Philippe Mathieu-Daudé
2023-09-22 18:20 ` [PATCH 0/4] aspeed: " Philippe Mathieu-Daudé
2023-09-22 19:00 ` Cédric Le Goater
2023-09-23 7:13 ` Markus Armbruster [this message]
2023-09-25 16:28 ` Cédric Le Goater
2023-09-26 6:44 ` Markus Armbruster
2023-09-29 6:46 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msxdmkeq.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.