From: David Michael <fedora.dm0@gmail.com>
To: robh@kernel.org, tomeu.vizoso@collabora.com
Cc: angelogioacchino.delregno@collabora.com,
boris.brezillon@collabora.com, alyssa.rosenzweig@collabora.com,
dri-devel@lists.freedesktop.org, steven.price@arm.com
Subject: [PATCH] drm/panfrost: Skip speed binning on EOPNOTSUPP
Date: Tue, 15 Aug 2023 21:42:41 -0400 [thread overview]
Message-ID: <87msyryd7y.fsf@gmail.com> (raw)
Encountered on an ARM Mali-T760 MP4, attempting to read the nvmem
variable can also return EOPNOTSUPP instead of ENOENT when speed
binning is unsupported.
Cc: <stable@vger.kernel.org>
Fixes: 7d690f936e9b ("drm/panfrost: Add basic support for speed binning")
Signed-off-by: David Michael <fedora.dm0@gmail.com>
---
Hi,
I upgraded an old Chromebook (veyron-minnie) to 6.4, and it fell back to
software rendering with "Cannot read speed-bin (-95)." in dmesg. Does
this error code also make sense to skip? Hardware acceleration seems to
work as it did previously with this change.
Thanks.
David
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
index 58dfb15a8757..e78de99e9933 100644
--- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
+++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
@@ -96,7 +96,7 @@ static int panfrost_read_speedbin(struct device *dev)
* keep going without it; any other error means that we are
* supposed to read the bin value, but we failed doing so.
*/
- if (ret != -ENOENT) {
+ if (ret != -ENOENT && ret != -EOPNOTSUPP) {
DRM_DEV_ERROR(dev, "Cannot read speed-bin (%d).", ret);
return ret;
}
--
2.41.0
next reply other threads:[~2023-08-16 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 1:42 David Michael [this message]
2023-08-16 9:45 ` [PATCH] drm/panfrost: Skip speed binning on EOPNOTSUPP Steven Price
2023-08-21 14:45 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msyryd7y.fsf@gmail.com \
--to=fedora.dm0@gmail.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.