From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0BF9525A for ; Tue, 15 Aug 2023 06:27:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A65DC433C7; Tue, 15 Aug 2023 06:27:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692080833; bh=AodI7zIGu1RaCkc0AQzN+Yz5PQHEep5hiT9BLg/KHro=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CDf5IRfBB1eW1wXf7GRdC0qxK3sY+Yu9bLNhbA5WKKxbQc1IxIbmmvHuZLY3fW8dd BdxZxPgL/0+Rd72V4sq7tCVPX+vJHUTYtjIjAD1hPYfFzN3m6dpLAuB5KETOVXurjg IppA8nG9DU+H3kmhjCoHaxnEwUNcSP6WJPNPUAr5hXic4Eow+9hMaFwxRTzCF5AFa4 87sGQaFe7NDKk+gl08LBXp6E/qvhYwY5F5fgmt6ZqkUEo+4tSSsoBqVNUBZePmTxIE XvAL3PK0D8WAcl7+geJMVIr3ebXq2ukpX2GImxOnNPeIdMITVgxMmXmmdAhjsM7X79 VJyvg8jg+r++g== Received: from [194.182.8.86] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qVnWI-004u14-PS; Tue, 15 Aug 2023 07:27:10 +0100 Date: Tue, 15 Aug 2023 07:27:21 +0100 Message-ID: <87msysq0qe.wl-maz@kernel.org> From: Marc Zyngier To: Shijie Huang Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Huang Shijie , Mark Rutland , Will Deacon , Frank Wang Subject: Re: [PATCH] KVM: arm64: pmu: Resync EL0 state on counter rotation In-Reply-To: <1ce05000-264e-1fda-d193-8b27c3c293d8@amperemail.onmicrosoft.com> References: <20230811180520.131727-1-maz@kernel.org> <1ce05000-264e-1fda-d193-8b27c3c293d8@amperemail.onmicrosoft.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 194.182.8.86 X-SA-Exim-Rcpt-To: shijie@amperemail.onmicrosoft.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, shijie@os.amperecomputing.com, mark.rutland@arm.com, will@kernel.org, zwang@amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 14 Aug 2023 03:58:32 +0100, Shijie Huang wrote: >=20 > Hi Marc, >=20 > =E5=9C=A8 2023/8/12 2:05, Marc Zyngier =E5=86=99=E9=81=93: > > Huang Shijie reports that, when profiling a guest from the host > > with a number of events that exceeds the number of available > > counters, the reported counts are wildly inaccurate. Without > > the counter oversubscription, the reported counts are correct. > >=20 > > Their investigation indicates that upon counter rotation (which > > takes place on the back of a timer interrupt), we fail to > > re-apply the guest EL0 enabling, leading to the counting of host > > events instead of guest events. > >=20 > > In order to solve this, add yet another hook between the host PMU > > driver and KVM, re-applying the guest EL0 configuration if the > > right conditions apply (the host is VHE, we are in interrupt > > context, and we interrupted a running vcpu). This triggers a new > > vcpu request which will apply the correct configuration on guest > > reentry. > >=20 > > With this, we have the correct counts, even when the counters are > > oversubscribed. > >=20 > > Reported-by: Huang Shijie > > Suggested-by: Oliver Upton > > Signed-off-by: Marc Zyngier > > Cc: Mark Rutland > > Cc: Will Deacon > > Link: https://lore.kernel.org/r/20230809013953.7692-1-shijie@os.amperec= omputing.com > > --- > > arch/arm64/include/asm/kvm_host.h | 1 + > > arch/arm64/kvm/arm.c | 3 +++ > > arch/arm64/kvm/pmu.c | 18 ++++++++++++++++++ > > drivers/perf/arm_pmuv3.c | 2 ++ > > include/kvm/arm_pmu.h | 2 ++ > > 5 files changed, 26 insertions(+) > >=20 > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm= /kvm_host.h > > index d3dd05bbfe23..553040e0e375 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -49,6 +49,7 @@ > > #define KVM_REQ_RELOAD_GICv4 KVM_ARCH_REQ(4) > > #define KVM_REQ_RELOAD_PMU KVM_ARCH_REQ(5) > > #define KVM_REQ_SUSPEND KVM_ARCH_REQ(6) > > +#define KVM_REQ_RESYNC_PMU_EL0 KVM_ARCH_REQ(7) > > #define KVM_DIRTY_LOG_MANUAL_CAPS > > (KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE | \ > > KVM_DIRTY_LOG_INITIALLY_SET) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > > index 72dc53a75d1c..978b0411082f 100644 > > --- a/arch/arm64/kvm/arm.c > > +++ b/arch/arm64/kvm/arm.c > > @@ -803,6 +803,9 @@ static int check_vcpu_requests(struct kvm_vcpu *vcp= u) > > kvm_pmu_handle_pmcr(vcpu, > > __vcpu_sys_reg(vcpu, PMCR_EL0)); > > + if (kvm_check_request(KVM_REQ_RESYNC_PMU_EL0, vcpu)) > > + kvm_vcpu_pmu_restore_guest(vcpu); > > + > > if (kvm_check_request(KVM_REQ_SUSPEND, vcpu)) > > return kvm_vcpu_suspend(vcpu); > > diff --git a/arch/arm64/kvm/pmu.c b/arch/arm64/kvm/pmu.c > > index 121f1a14c829..0eea225fd09a 100644 > > --- a/arch/arm64/kvm/pmu.c > > +++ b/arch/arm64/kvm/pmu.c > > @@ -236,3 +236,21 @@ bool kvm_set_pmuserenr(u64 val) > > ctxt_sys_reg(hctxt, PMUSERENR_EL0) =3D val; > > return true; > > } > > + > > +/* > > + * If we interrupted the guest to update the host PMU context, make > > + * sure we re-apply the guest EL0 state. > > + */ > > +void kvm_vcpu_pmu_resync_el0(void) > > +{ > > + struct kvm_vcpu *vcpu; > > + > > + if (!has_vhe() || !in_interrupt()) > > + return; > > + > > + vcpu =3D kvm_get_running_vcpu(); > > + if (!vcpu) > > + return; > > + > > + kvm_make_request(KVM_REQ_RESYNC_PMU_EL0, vcpu); > > +} > > diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c > > index 08b3a1bf0ef6..6a3d8176f54a 100644 > > --- a/drivers/perf/arm_pmuv3.c > > +++ b/drivers/perf/arm_pmuv3.c > > @@ -772,6 +772,8 @@ static void armv8pmu_start(struct arm_pmu *cpu_pmu) > > /* Enable all counters */ > > armv8pmu_pmcr_write(armv8pmu_pmcr_read() | ARMV8_PMU_PMCR_E); > > + > > + kvm_vcpu_pmu_resync_el0(); > > } >=20 > I read the perf code again, and find it maybe not good to do it in > armv8pmu_start. >=20 > =C2=A0=C2=A0 Assume we install a new perf event to a CPU "x" from CPU 0,= =C2=A0 a VM > guest is running on CPU "x": >=20 > =C2=A0=C2=A0=C2=A0 perf_event_open() --> perf_install_in_context() --> >=20 > =C2=A0=C2=A0=C2=A0 call this function in=C2=A0 IPI interrupt: ___perf_ins= tall_in_context(). >=20 > =C2=A0=C2=A0 armv8pmu_start() will be called in ___perf_install_in_contex= t() in IPI. >=20 > =C2=A0=C2=A0 so kvm_vcpu_pmu_resync_el0() will _make_ a request by meetin= g the > conditions: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = 1.) in interrupt context. >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = 2.) a guest is running on this CPU. >=20 >=20 > But in actually, the request should not send out. Why shouldn't it be applied? This isn't supposed to be always necessary, but it needs to be applied whenever there is a possibility for counters to be updated behind our back, something that is a pretty event anyway. > Please correct me if I am wrong. >=20 > IMHO, the best solution is add=C2=A0 a hook in the perf/core code, and ma= ke > the request there. I disagree. I'm still completely opposed to anything that will add such a hook in the core perf code, specially as a weak symbol. The interactions must be strictly between the PMUv3 driver and KVM, because they are the only parties involved here. I will *not* take such a patch. M. --=20 Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6177DC001DE for ; Tue, 15 Aug 2023 06:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5UWiOn80Xr+Prp5TtwZG7gQHWRt20UPiq4Sx1tMeWPk=; b=ljERRmKR+N2JFo SY/Rqe9YxK1iZ+4Nwr/Mwf1GZ0LzkJkJ7C45y8ec/JeAYLzHXP1YT9kv3HrWsH+fot+qAChocLl2P 6Ti1sDF0eUj4equAvDMRHZC2SDeiU9yR6bzWbhxD/o9tQOJ9H4pMoS9eoRYu5yRyO2G4kxQieB0oj 89LXjbisGHk3ufqrA1y2xhiSIo34dOE0vafNXQtldYrqws71VUkfpnkEvVLu30Q50YHcSurTL/6mt 0Im2bFoxbBN4H/cneD4cLBge1xi6lVdWGmQz2krlSELTHtx5x6yjNqc3yv9+BISsPnQS41fP0i6he OIkWS7NsTZI9K2dr/FNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVnWS-000zoe-30; Tue, 15 Aug 2023 06:27:20 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVnWO-000zo5-1l for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 06:27:18 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1801B60EB2; Tue, 15 Aug 2023 06:27:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A65DC433C7; Tue, 15 Aug 2023 06:27:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692080833; bh=AodI7zIGu1RaCkc0AQzN+Yz5PQHEep5hiT9BLg/KHro=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CDf5IRfBB1eW1wXf7GRdC0qxK3sY+Yu9bLNhbA5WKKxbQc1IxIbmmvHuZLY3fW8dd BdxZxPgL/0+Rd72V4sq7tCVPX+vJHUTYtjIjAD1hPYfFzN3m6dpLAuB5KETOVXurjg IppA8nG9DU+H3kmhjCoHaxnEwUNcSP6WJPNPUAr5hXic4Eow+9hMaFwxRTzCF5AFa4 87sGQaFe7NDKk+gl08LBXp6E/qvhYwY5F5fgmt6ZqkUEo+4tSSsoBqVNUBZePmTxIE XvAL3PK0D8WAcl7+geJMVIr3ebXq2ukpX2GImxOnNPeIdMITVgxMmXmmdAhjsM7X79 VJyvg8jg+r++g== Received: from [194.182.8.86] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qVnWI-004u14-PS; Tue, 15 Aug 2023 07:27:10 +0100 Date: Tue, 15 Aug 2023 07:27:21 +0100 Message-ID: <87msysq0qe.wl-maz@kernel.org> From: Marc Zyngier To: Shijie Huang Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Huang Shijie , Mark Rutland , Will Deacon , Frank Wang Subject: Re: [PATCH] KVM: arm64: pmu: Resync EL0 state on counter rotation In-Reply-To: <1ce05000-264e-1fda-d193-8b27c3c293d8@amperemail.onmicrosoft.com> References: <20230811180520.131727-1-maz@kernel.org> <1ce05000-264e-1fda-d193-8b27c3c293d8@amperemail.onmicrosoft.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 194.182.8.86 X-SA-Exim-Rcpt-To: shijie@amperemail.onmicrosoft.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com, shijie@os.amperecomputing.com, mark.rutland@arm.com, will@kernel.org, zwang@amperecomputing.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230814_232717_339628_805CC0AA X-CRM114-Status: GOOD ( 42.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAxNCBBdWcgMjAyMyAwMzo1ODozMiArMDEwMCwKU2hpamllIEh1YW5nIDxzaGlqaWVA YW1wZXJlbWFpbC5vbm1pY3Jvc29mdC5jb20+IHdyb3RlOgo+IAo+IEhpIE1hcmMsCj4gCj4g5Zyo IDIwMjMvOC8xMiAyOjA1LCBNYXJjIFp5bmdpZXIg5YaZ6YGTOgo+ID4gSHVhbmcgU2hpamllIHJl cG9ydHMgdGhhdCwgd2hlbiBwcm9maWxpbmcgYSBndWVzdCBmcm9tIHRoZSBob3N0Cj4gPiB3aXRo IGEgbnVtYmVyIG9mIGV2ZW50cyB0aGF0IGV4Y2VlZHMgdGhlIG51bWJlciBvZiBhdmFpbGFibGUK PiA+IGNvdW50ZXJzLCB0aGUgcmVwb3J0ZWQgY291bnRzIGFyZSB3aWxkbHkgaW5hY2N1cmF0ZS4g V2l0aG91dAo+ID4gdGhlIGNvdW50ZXIgb3ZlcnN1YnNjcmlwdGlvbiwgdGhlIHJlcG9ydGVkIGNv dW50cyBhcmUgY29ycmVjdC4KPiA+IAo+ID4gVGhlaXIgaW52ZXN0aWdhdGlvbiBpbmRpY2F0ZXMg dGhhdCB1cG9uIGNvdW50ZXIgcm90YXRpb24gKHdoaWNoCj4gPiB0YWtlcyBwbGFjZSBvbiB0aGUg YmFjayBvZiBhIHRpbWVyIGludGVycnVwdCksIHdlIGZhaWwgdG8KPiA+IHJlLWFwcGx5IHRoZSBn dWVzdCBFTDAgZW5hYmxpbmcsIGxlYWRpbmcgdG8gdGhlIGNvdW50aW5nIG9mIGhvc3QKPiA+IGV2 ZW50cyBpbnN0ZWFkIG9mIGd1ZXN0IGV2ZW50cy4KPiA+IAo+ID4gSW4gb3JkZXIgdG8gc29sdmUg dGhpcywgYWRkIHlldCBhbm90aGVyIGhvb2sgYmV0d2VlbiB0aGUgaG9zdCBQTVUKPiA+IGRyaXZl ciBhbmQgS1ZNLCByZS1hcHBseWluZyB0aGUgZ3Vlc3QgRUwwIGNvbmZpZ3VyYXRpb24gaWYgdGhl Cj4gPiByaWdodCBjb25kaXRpb25zIGFwcGx5ICh0aGUgaG9zdCBpcyBWSEUsIHdlIGFyZSBpbiBp bnRlcnJ1cHQKPiA+IGNvbnRleHQsIGFuZCB3ZSBpbnRlcnJ1cHRlZCBhIHJ1bm5pbmcgdmNwdSku IFRoaXMgdHJpZ2dlcnMgYSBuZXcKPiA+IHZjcHUgcmVxdWVzdCB3aGljaCB3aWxsIGFwcGx5IHRo ZSBjb3JyZWN0IGNvbmZpZ3VyYXRpb24gb24gZ3Vlc3QKPiA+IHJlZW50cnkuCj4gPiAKPiA+IFdp dGggdGhpcywgd2UgaGF2ZSB0aGUgY29ycmVjdCBjb3VudHMsIGV2ZW4gd2hlbiB0aGUgY291bnRl cnMgYXJlCj4gPiBvdmVyc3Vic2NyaWJlZC4KPiA+IAo+ID4gUmVwb3J0ZWQtYnk6IEh1YW5nIFNo aWppZSA8c2hpamllQG9zLmFtcGVyZWNvbXB1dGluZy5jb20+Cj4gPiBTdWdnZXN0ZWQtYnk6IE9s aXZlciBVcHRvbiA8b2xpdmVyLnVwdG9uQGxpbnV4LmRldj4KPiA+IFNpZ25lZC1vZmYtYnk6IE1h cmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+Cj4gPiBDYzogTWFyayBSdXRsYW5kIDxtYXJrLnJ1 dGxhbmRAYXJtLmNvbT4KPiA+IENjOiBXaWxsIERlYWNvbiA8d2lsbEBrZXJuZWwub3JnPgo+ID4g TGluazogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvci8yMDIzMDgwOTAxMzk1My43NjkyLTEtc2hp amllQG9zLmFtcGVyZWNvbXB1dGluZy5jb20KPiA+IC0tLQo+ID4gICBhcmNoL2FybTY0L2luY2x1 ZGUvYXNtL2t2bV9ob3N0LmggfCAgMSArCj4gPiAgIGFyY2gvYXJtNjQva3ZtL2FybS5jICAgICAg ICAgICAgICB8ICAzICsrKwo+ID4gICBhcmNoL2FybTY0L2t2bS9wbXUuYyAgICAgICAgICAgICAg fCAxOCArKysrKysrKysrKysrKysrKysKPiA+ICAgZHJpdmVycy9wZXJmL2FybV9wbXV2My5jICAg ICAgICAgIHwgIDIgKysKPiA+ICAgaW5jbHVkZS9rdm0vYXJtX3BtdS5oICAgICAgICAgICAgIHwg IDIgKysKPiA+ICAgNSBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRp ZmYgLS1naXQgYS9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9ob3N0LmggYi9hcmNoL2FybTY0 L2luY2x1ZGUvYXNtL2t2bV9ob3N0LmgKPiA+IGluZGV4IGQzZGQwNWJiZmUyMy4uNTUzMDQwZTBl Mzc1IDEwMDY0NAo+ID4gLS0tIGEvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9rdm1faG9zdC5oCj4g PiArKysgYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2t2bV9ob3N0LmgKPiA+IEBAIC00OSw2ICs0 OSw3IEBACj4gPiAgICNkZWZpbmUgS1ZNX1JFUV9SRUxPQURfR0lDdjQJS1ZNX0FSQ0hfUkVRKDQp Cj4gPiAgICNkZWZpbmUgS1ZNX1JFUV9SRUxPQURfUE1VCUtWTV9BUkNIX1JFUSg1KQo+ID4gICAj ZGVmaW5lIEtWTV9SRVFfU1VTUEVORAkJS1ZNX0FSQ0hfUkVRKDYpCj4gPiArI2RlZmluZSBLVk1f UkVRX1JFU1lOQ19QTVVfRUwwCUtWTV9BUkNIX1JFUSg3KQo+ID4gICAgICNkZWZpbmUgS1ZNX0RJ UlRZX0xPR19NQU5VQUxfQ0FQUwo+ID4gKEtWTV9ESVJUWV9MT0dfTUFOVUFMX1BST1RFQ1RfRU5B QkxFIHwgXAo+ID4gICAJCQkJICAgICBLVk1fRElSVFlfTE9HX0lOSVRJQUxMWV9TRVQpCj4gPiBk aWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vYXJtLmMgYi9hcmNoL2FybTY0L2t2bS9hcm0uYwo+ ID4gaW5kZXggNzJkYzUzYTc1ZDFjLi45NzhiMDQxMTA4MmYgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNo L2FybTY0L2t2bS9hcm0uYwo+ID4gKysrIGIvYXJjaC9hcm02NC9rdm0vYXJtLmMKPiA+IEBAIC04 MDMsNiArODAzLDkgQEAgc3RhdGljIGludCBjaGVja192Y3B1X3JlcXVlc3RzKHN0cnVjdCBrdm1f dmNwdSAqdmNwdSkKPiA+ICAgCQkJa3ZtX3BtdV9oYW5kbGVfcG1jcih2Y3B1LAo+ID4gICAJCQkJ CSAgICBfX3ZjcHVfc3lzX3JlZyh2Y3B1LCBQTUNSX0VMMCkpOwo+ID4gICArCQlpZiAoa3ZtX2No ZWNrX3JlcXVlc3QoS1ZNX1JFUV9SRVNZTkNfUE1VX0VMMCwgdmNwdSkpCj4gPiArCQkJa3ZtX3Zj cHVfcG11X3Jlc3RvcmVfZ3Vlc3QodmNwdSk7Cj4gPiArCj4gPiAgIAkJaWYgKGt2bV9jaGVja19y ZXF1ZXN0KEtWTV9SRVFfU1VTUEVORCwgdmNwdSkpCj4gPiAgIAkJCXJldHVybiBrdm1fdmNwdV9z dXNwZW5kKHZjcHUpOwo+ID4gICBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vcG11LmMgYi9h cmNoL2FybTY0L2t2bS9wbXUuYwo+ID4gaW5kZXggMTIxZjFhMTRjODI5Li4wZWVhMjI1ZmQwOWEg MTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL2FybTY0L2t2bS9wbXUuYwo+ID4gKysrIGIvYXJjaC9hcm02 NC9rdm0vcG11LmMKPiA+IEBAIC0yMzYsMyArMjM2LDIxIEBAIGJvb2wga3ZtX3NldF9wbXVzZXJl bnIodTY0IHZhbCkKPiA+ICAgCWN0eHRfc3lzX3JlZyhoY3R4dCwgUE1VU0VSRU5SX0VMMCkgPSB2 YWw7Cj4gPiAgIAlyZXR1cm4gdHJ1ZTsKPiA+ICAgfQo+ID4gKwo+ID4gKy8qCj4gPiArICogSWYg d2UgaW50ZXJydXB0ZWQgdGhlIGd1ZXN0IHRvIHVwZGF0ZSB0aGUgaG9zdCBQTVUgY29udGV4dCwg bWFrZQo+ID4gKyAqIHN1cmUgd2UgcmUtYXBwbHkgdGhlIGd1ZXN0IEVMMCBzdGF0ZS4KPiA+ICsg Ki8KPiA+ICt2b2lkIGt2bV92Y3B1X3BtdV9yZXN5bmNfZWwwKHZvaWQpCj4gPiArewo+ID4gKwlz dHJ1Y3Qga3ZtX3ZjcHUgKnZjcHU7Cj4gPiArCj4gPiArCWlmICghaGFzX3ZoZSgpIHx8ICFpbl9p bnRlcnJ1cHQoKSkKPiA+ICsJCXJldHVybjsKPiA+ICsKPiA+ICsJdmNwdSA9IGt2bV9nZXRfcnVu bmluZ192Y3B1KCk7Cj4gPiArCWlmICghdmNwdSkKPiA+ICsJCXJldHVybjsKPiA+ICsKPiA+ICsJ a3ZtX21ha2VfcmVxdWVzdChLVk1fUkVRX1JFU1lOQ19QTVVfRUwwLCB2Y3B1KTsKPiA+ICt9Cj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wZXJmL2FybV9wbXV2My5jIGIvZHJpdmVycy9wZXJmL2Fy bV9wbXV2My5jCj4gPiBpbmRleCAwOGIzYTFiZjBlZjYuLjZhM2Q4MTc2ZjU0YSAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvcGVyZi9hcm1fcG11djMuYwo+ID4gKysrIGIvZHJpdmVycy9wZXJmL2Fy bV9wbXV2My5jCj4gPiBAQCAtNzcyLDYgKzc3Miw4IEBAIHN0YXRpYyB2b2lkIGFybXY4cG11X3N0 YXJ0KHN0cnVjdCBhcm1fcG11ICpjcHVfcG11KQo+ID4gICAgIAkvKiBFbmFibGUgYWxsIGNvdW50 ZXJzICovCj4gPiAgIAlhcm12OHBtdV9wbWNyX3dyaXRlKGFybXY4cG11X3BtY3JfcmVhZCgpIHwg QVJNVjhfUE1VX1BNQ1JfRSk7Cj4gPiArCj4gPiArCWt2bV92Y3B1X3BtdV9yZXN5bmNfZWwwKCk7 Cj4gPiAgIH0KPiAKPiBJIHJlYWQgdGhlIHBlcmYgY29kZSBhZ2FpbiwgYW5kIGZpbmQgaXQgbWF5 YmUgbm90IGdvb2QgdG8gZG8gaXQgaW4KPiBhcm12OHBtdV9zdGFydC4KPiAKPiDCoMKgIEFzc3Vt ZSB3ZSBpbnN0YWxsIGEgbmV3IHBlcmYgZXZlbnQgdG8gYSBDUFUgIngiIGZyb20gQ1BVIDAswqAg YSBWTQo+IGd1ZXN0IGlzIHJ1bm5pbmcgb24gQ1BVICJ4IjoKPiAKPiDCoMKgwqAgcGVyZl9ldmVu dF9vcGVuKCkgLS0+IHBlcmZfaW5zdGFsbF9pbl9jb250ZXh0KCkgLS0+Cj4gCj4gwqDCoMKgIGNh bGwgdGhpcyBmdW5jdGlvbiBpbsKgIElQSSBpbnRlcnJ1cHQ6IF9fX3BlcmZfaW5zdGFsbF9pbl9j b250ZXh0KCkuCj4gCj4gwqDCoCBhcm12OHBtdV9zdGFydCgpIHdpbGwgYmUgY2FsbGVkIGluIF9f X3BlcmZfaW5zdGFsbF9pbl9jb250ZXh0KCkgaW4gSVBJLgo+IAo+IMKgwqAgc28ga3ZtX3ZjcHVf cG11X3Jlc3luY19lbDAoKSB3aWxsIF9tYWtlXyBhIHJlcXVlc3QgYnkgbWVldGluZyB0aGUKPiBj b25kaXRpb25zOgo+IAo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAxLikgaW4gaW50ZXJydXB0 IGNvbnRleHQuCj4gCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDIuKSBhIGd1ZXN0IGlzIHJ1 bm5pbmcgb24gdGhpcyBDUFUuCj4gCj4gCj4gQnV0IGluIGFjdHVhbGx5LCB0aGUgcmVxdWVzdCBz aG91bGQgbm90IHNlbmQgb3V0LgoKV2h5IHNob3VsZG4ndCBpdCBiZSBhcHBsaWVkPyBUaGlzIGlz bid0IHN1cHBvc2VkIHRvIGJlIGFsd2F5cwpuZWNlc3NhcnksIGJ1dCBpdCBuZWVkcyB0byBiZSBh cHBsaWVkIHdoZW5ldmVyIHRoZXJlIGlzIGEgcG9zc2liaWxpdHkKZm9yIGNvdW50ZXJzIHRvIGJl IHVwZGF0ZWQgYmVoaW5kIG91ciBiYWNrLCBzb21ldGhpbmcgdGhhdCBpcyBhIHByZXR0eQpldmVu dCBhbnl3YXkuCgo+IFBsZWFzZSBjb3JyZWN0IG1lIGlmIEkgYW0gd3JvbmcuCj4gCj4gSU1ITywg dGhlIGJlc3Qgc29sdXRpb24gaXMgYWRkwqAgYSBob29rIGluIHRoZSBwZXJmL2NvcmUgY29kZSwg YW5kIG1ha2UKPiB0aGUgcmVxdWVzdCB0aGVyZS4KCkkgZGlzYWdyZWUuIEknbSBzdGlsbCBjb21w bGV0ZWx5IG9wcG9zZWQgdG8gYW55dGhpbmcgdGhhdCB3aWxsIGFkZApzdWNoIGEgaG9vayBpbiB0 aGUgY29yZSBwZXJmIGNvZGUsIHNwZWNpYWxseSBhcyBhIHdlYWsgc3ltYm9sLiBUaGUKaW50ZXJh Y3Rpb25zIG11c3QgYmUgc3RyaWN0bHkgYmV0d2VlbiB0aGUgUE1VdjMgZHJpdmVyIGFuZCBLVk0s CmJlY2F1c2UgdGhleSBhcmUgdGhlIG9ubHkgcGFydGllcyBpbnZvbHZlZCBoZXJlLgoKSSB3aWxs ICpub3QqIHRha2Ugc3VjaCBhIHBhdGNoLgoKCU0uCgotLSAKV2l0aG91dCBkZXZpYXRpb24gZnJv bSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=