All of lore.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Jeff Layton <jlayton@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>,
	Frank Sorenson <sorenson@redhat.com>, Jan Kara <jack@suse.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] fat: make fat_update_time get its own timestamp
Date: Fri, 11 Aug 2023 02:31:15 +0900	[thread overview]
Message-ID: <87msyyn6sc.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20230810-ctime-fat-v1-2-327598fd1de8@kernel.org> (Jeff Layton's message of "Thu, 10 Aug 2023 09:12:05 -0400")

Jeff Layton <jlayton@kernel.org> writes:

> In later patches, we're going to drop the "now" parameter from the
> update_time operation. Fix fat_update_time to fetch its own timestamp.
> It turns out that this is easily done by just passing a NULL timestamp
> pointer to fat_truncate_time.
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Thanks.

> ---
>  fs/fat/misc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> index 37f4afb346af..f2304a1054aa 100644
> --- a/fs/fat/misc.c
> +++ b/fs/fat/misc.c
> @@ -347,7 +347,7 @@ int fat_update_time(struct inode *inode, int flags)
>  		return 0;
>  
>  	if (flags & (S_ATIME | S_CTIME | S_MTIME)) {
> -		fat_truncate_time(inode, now, flags);
> +		fat_truncate_time(inode, NULL, flags);
>  		if (inode->i_sb->s_flags & SB_LAZYTIME)
>  			dirty_flags |= I_DIRTY_TIME;
>  		else

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  parent reply	other threads:[~2023-08-10 17:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 13:12 [PATCH 0/2] fat: revise the FAT patches for mgtime series Jeff Layton
2023-08-10 13:12 ` [PATCH 1/2] fat: remove i_version handling from fat_update_time Jeff Layton
2023-08-10 13:21   ` Jan Kara
2023-08-10 17:31   ` OGAWA Hirofumi
2023-08-10 18:04   ` Frank Sorenson
2023-08-10 13:12 ` [PATCH 2/2] fat: make fat_update_time get its own timestamp Jeff Layton
2023-08-10 13:22   ` Jan Kara
2023-08-10 17:31   ` OGAWA Hirofumi [this message]
2023-08-10 18:05   ` Frank Sorenson
2023-08-10 13:13 ` [PATCH 0/2] fat: revise the FAT patches for mgtime series Christian Brauner
2023-08-11  7:06 ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87msyyn6sc.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=brauner@kernel.org \
    --cc=jack@suse.com \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sorenson@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.