From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8896C77B71 for ; Fri, 21 Apr 2023 15:13:29 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 16C3DE8F; Fri, 21 Apr 2023 17:12:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 16C3DE8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1682090007; bh=r9J1Hp87UG04HUAkzR9MjKMcsmluj2I0+/KMvP5cBXU=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=NWCoaVZvI45focqoKfzUXHyvNey/apVtDjucapkNFzQ4mwNsa1YaWDB4dX8JGgTml k5u1o+KYFZKXN0EDslDb+v4XSFjF8gOSgO2/y1prG6I7AqoPm4k6UeJeTq0tuopD5A yFOY1qxa0b0SsXNSlxPMHNzvdKzns+EU4GPOsPb4= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id DC34AF80155; Fri, 21 Apr 2023 17:12:11 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9BD03F80155; Fri, 21 Apr 2023 17:12:08 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 92898F80053 for ; Fri, 21 Apr 2023 17:12:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 92898F80053 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=m4QzAOYY; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=L7jyBMY9 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ACCCC21A2F; Fri, 21 Apr 2023 15:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682089920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pB+SaarZkswQ/Ojvq8IRHEQLm9aa2k8O20tyEXe9Ttk=; b=m4QzAOYY+p0BUDAoshRgoAQZPHsp25Eo+rXYfxamvg3RZxXIxSdWveuandX2Zi8tYbyxh/ ZtT5zrcHa0NEq5QvloF5sltO7Keps8PbnqyTjK7g7NEa84zT9Yp+49wIOkiwuoGqtpZfL0 77RNmIUqwwvrqtkU4TYOmCng13wF+c8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682089920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pB+SaarZkswQ/Ojvq8IRHEQLm9aa2k8O20tyEXe9Ttk=; b=L7jyBMY90E1QCULSBruK640aKq0CC1MXYiZUu8X2WeSOFdlimbBU91LdIhCLC9tOBKb+A5 m8TjO1+O3BSHR9Dw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 765EB1390E; Fri, 21 Apr 2023 15:12:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id l96vG8CnQmRbFAAAMHmgww (envelope-from ); Fri, 21 Apr 2023 15:12:00 +0000 Date: Fri, 21 Apr 2023 17:11:59 +0200 Message-ID: <87mt31qngg.wl-tiwai@suse.de> From: Takashi Iwai To: Chris Down Subject: Re: [PATCH] usb-audio: Rate limit usb_set_interface error reporting In-Reply-To: References: <87wn25qosu.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: CBFWBA4XU5VY7O4QQIJABFYRHRW62WVF X-Message-ID-Hash: CBFWBA4XU5VY7O4QQIJABFYRHRW62WVF X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Apr 2023 16:48:27 +0200, Chris Down wrote: > > Hi Takashi, > > Takashi Iwai writes: > > This patch itself is safe and good to have, so I'm going to take it as > > is. > > Thanks! > > > But I'm still curious in which code path the problem happens. That > > is, we should address such unnecessary repeats if possible. Do you > > have some more data? > > Unfortunately not, I've been running with a kernel testing some other > mm changes recently so haven't had a chance to debug what's going on > here. But it starts like this: > > [Fri Apr 21 13:21:10 2023] usb 3-7: USB disconnect, device number 39 > [Fri Apr 21 13:21:10 2023] usb 3-7.1: USB disconnect, device number 40 > [Fri Apr 21 13:21:10 2023] usb 3-7.1.1: USB disconnect, device number 42 > [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb (err = -19) > [Fri Apr 21 13:21:10 2023] usb 3-7.4: Unable to submit urb #2: -19 at snd_usb_queue_pending_output_urbs > [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device > [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device > [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device > [Fri Apr 21 13:21:10 2023] usb 3-7.4: 1:0: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.4: 2:0: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.2: USB disconnect, device number 44 > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [... thousands of messages ensue ...] > > So it looks like maybe some ordering is not quite right in > destruction, perhaps only on multi-level USB topologies? Hrm, is "usb 3-7.1.4" really the USB audio device? The previous errors like "Unable to submit urb #2..." are certainly for USB audio, and those are with "usb 3-7.4". You patch may still make sense, though. So I'll keep it applied. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA95CC7618E for ; Fri, 21 Apr 2023 15:12:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232769AbjDUPMP (ORCPT ); Fri, 21 Apr 2023 11:12:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230472AbjDUPMM (ORCPT ); Fri, 21 Apr 2023 11:12:12 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E5E313855 for ; Fri, 21 Apr 2023 08:12:03 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ACCCC21A2F; Fri, 21 Apr 2023 15:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682089920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pB+SaarZkswQ/Ojvq8IRHEQLm9aa2k8O20tyEXe9Ttk=; b=m4QzAOYY+p0BUDAoshRgoAQZPHsp25Eo+rXYfxamvg3RZxXIxSdWveuandX2Zi8tYbyxh/ ZtT5zrcHa0NEq5QvloF5sltO7Keps8PbnqyTjK7g7NEa84zT9Yp+49wIOkiwuoGqtpZfL0 77RNmIUqwwvrqtkU4TYOmCng13wF+c8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682089920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pB+SaarZkswQ/Ojvq8IRHEQLm9aa2k8O20tyEXe9Ttk=; b=L7jyBMY90E1QCULSBruK640aKq0CC1MXYiZUu8X2WeSOFdlimbBU91LdIhCLC9tOBKb+A5 m8TjO1+O3BSHR9Dw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 765EB1390E; Fri, 21 Apr 2023 15:12:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id l96vG8CnQmRbFAAAMHmgww (envelope-from ); Fri, 21 Apr 2023 15:12:00 +0000 Date: Fri, 21 Apr 2023 17:11:59 +0200 Message-ID: <87mt31qngg.wl-tiwai@suse.de> From: Takashi Iwai To: Chris Down Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH] usb-audio: Rate limit usb_set_interface error reporting In-Reply-To: References: <87wn25qosu.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Apr 2023 16:48:27 +0200, Chris Down wrote: > > Hi Takashi, > > Takashi Iwai writes: > > This patch itself is safe and good to have, so I'm going to take it as > > is. > > Thanks! > > > But I'm still curious in which code path the problem happens. That > > is, we should address such unnecessary repeats if possible. Do you > > have some more data? > > Unfortunately not, I've been running with a kernel testing some other > mm changes recently so haven't had a chance to debug what's going on > here. But it starts like this: > > [Fri Apr 21 13:21:10 2023] usb 3-7: USB disconnect, device number 39 > [Fri Apr 21 13:21:10 2023] usb 3-7.1: USB disconnect, device number 40 > [Fri Apr 21 13:21:10 2023] usb 3-7.1.1: USB disconnect, device number 42 > [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb (err = -19) > [Fri Apr 21 13:21:10 2023] usb 3-7.4: Unable to submit urb #2: -19 at snd_usb_queue_pending_output_urbs > [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device > [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device > [Fri Apr 21 13:21:10 2023] usb 3-7.4: cannot submit urb 0, error -19: no device > [Fri Apr 21 13:21:10 2023] usb 3-7.4: 1:0: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.4: 2:0: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.2: USB disconnect, device number 44 > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [Fri Apr 21 13:21:10 2023] usb 3-7.1.4: 1:1: usb_set_interface failed (-19) > [... thousands of messages ensue ...] > > So it looks like maybe some ordering is not quite right in > destruction, perhaps only on multi-level USB topologies? Hrm, is "usb 3-7.1.4" really the USB audio device? The previous errors like "Unable to submit urb #2..." are certainly for USB audio, and those are with "usb 3-7.4". You patch may still make sense, though. So I'll keep it applied. thanks, Takashi