From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDDADC64ED8 for ; Mon, 27 Feb 2023 12:36:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 64A2310E03A; Mon, 27 Feb 2023 12:36:59 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id C059310E03A for ; Mon, 27 Feb 2023 12:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677501417; x=1709037417; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=BAn8bIXoV7EggjTh8A0AKZnaPYQCthmosuDoFdtrqlc=; b=V3Y2oLmqAPc9V3cErWf8tQzxKL1XPX+29c1THDReFcU34Lp/P9XP+1Mm 7jgzK1HFaMg7axEmmr9GqzB/usSzTfRJk+zGa6av6g0iS6f0wsQJgsBIk 1dsaLaIiPd/6yxUXEFSKaXtyca1Khl+BfIW31j9iGIGSxeau2GfXWkrRb VFmsyq1y4q6Uo+LY3dR9ttijnSqq73ISL/DYju8j5nbWZYB/L/+Z+IzHG ipatCkvRnxikUECroT7+5tzyAT5ax/1gREv1HtfJy/8goYD0/aE26KmAT oHSZIQAexRVqukDN9pYHH52hZU8q54TgTEtW/0i4CjkESqprjDZJNacwi A==; X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="335328032" X-IronPort-AV: E=Sophos;i="5.97,332,1669104000"; d="scan'208";a="335328032" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 04:36:57 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10633"; a="737683311" X-IronPort-AV: E=Sophos;i="5.97,332,1669104000"; d="scan'208";a="737683311" Received: from jkaisrli-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.56.158]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 04:36:55 -0800 From: Jani Nikula To: Ville =?utf-8?B?U3lyasOkbMOk?= , "Shankar, Uma" In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230220151731.6852-1-ville.syrjala@linux.intel.com> Date: Mon, 27 Feb 2023 14:36:52 +0200 Message-ID: <87mt4z1dzv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix audio ELD handling for DP MST X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 23 Feb 2023, Ville Syrj=C3=A4l=C3=A4 wrote: > On Thu, Feb 23, 2023 at 05:01:11PM +0000, Shankar, Uma wrote: >>=20 >>=20 >> > -----Original Message----- >> > From: Ville Syrj=C3=A4l=C3=A4 >> > Sent: Thursday, February 23, 2023 8:37 PM >> > To: Shankar, Uma >> > Cc: intel-gfx@lists.freedesktop.org >> > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix audio ELD handling = for DP MST >> >=20 >> > On Wed, Feb 22, 2023 at 05:59:45PM +0000, Shankar, Uma wrote: >> > > >> > > >> > > > -----Original Message----- >> > > > From: Intel-gfx On Behalf >> > > > Of Ville Syrjala >> > > > Sent: Monday, February 20, 2023 8:48 PM >> > > > To: intel-gfx@lists.freedesktop.org >> > > > Subject: [Intel-gfx] [PATCH 1/2] drm/i915: Fix audio ELD handling >> > > > for DP MST >> > > >> > > Nit: May be append "display" to drm/i915. >> >=20 >> > Don't think I've ever used that one. Seems a bit too generic to provid= e any real >> > additional information to the table that wouldn't usually be obvious f= rom the subject >> > anyway. >> > Do other people find /display useful? >> >=20 >> > I guess I could have used a more specific /mst in this case, but then = again I already >> > mention MST in the subject anyway so seems a bit redundant. >>=20 >> I think there are mixed declarations in our tree, no clear rule as such. >> Will leave it you, maybe a general guideline would be good to make it >> all consistent. > > Yeah, some general guidelines might be good to figure out. > > In the meantime I've pushed these patches as is for now. > Thanks for the review. Personally I only ever use drm/i915/display when it's really about *everything* related to display, the highest level display stuff. Never for details like this. BR, Jani. --=20 Jani Nikula, Intel Open Source Graphics Center